fix: Panic while rendering function type hint with impl trait arg #17832
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
ShoyuVanilla
commented
Aug 8, 2024
| let (fn_params, other) = | ||
| parameters.split_at(self_param as usize + type_ + const_ + lifetime); | ||
| let (_impl, parent_params) = other.split_at(impl_); | ||
| let (fn_params, parent_params) = parameters.split_at(without_impl + impl_); |
Member
Author
There was a problem hiding this comment.
as generic_args is self + type params + const params + lifetimes + hidden generic with impl trait args, we should include impl to generate generic_args_sans_defaults
ShoyuVanilla
commented
Aug 8, 2024
| let fn_params = | ||
| generic_args_sans_defaults(f, Some(generic_def_id), fn_params); | ||
| &generic_args_sans_defaults(f, Some(generic_def_id), fn_params) | ||
| [0..without_impl]; |
Member
Author
There was a problem hiding this comment.
And we exclude impl trait things here
ShoyuVanilla
changed the title
Veykril
approved these changes
Aug 8, 2024
Member
|
Thanks! |
Contributor
Contributor
Contributor
|
☀️ Test successful - checks-actions |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #17811