This repository was archived by the owner on Apr 28, 2025. It is now read-only.
Use rustdoc JSON for API list, add functions that were missing
#384
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We want to be able to adjust our configuration based on whether we are running in CI, propagate this so our tests can use it.
tgross35
force-pushed
the
api-list
branch
2 times, most recently
from
c3df7d8 to
cee4646
Compare
Rather than collecting a list of file names in `libm-test/build.rs`, just use a script to parse rustdoc's JSON output.
Now that we are using rustdoc output to locate public functions, the test is indicating a few that were missed since they don't have their own function. Update everything to now include the following routines: * `erfc` * `erfcf` * `y0` * `y0f` * `y1` * `y1f` * `yn` * `ynf`
tgross35
added a commit
that referenced
this pull request
Apr 18, 2025
Use `rustdoc` JSON for API list, add functions that were missing
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than collecting a list of file names in
libm-test/build.rs, just use a script to parse rustdoc's JSON output. This new method found a handful of functions that were not being tested because they are in the same file as other functions:erfcerfcfy0y0fy1y1fynynfUpdate tests so these are now included.