log the URL that caused a 404 #300
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thanks. I also think its much better if we remove that debug message in src/web/mod.rs in the future. That message is causing so much noise in the our main log file. We can just use web servers log file for 404 requests. Also IIRC there was some bug in that message but I can't remember 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When inspecting logs for the server process, there are a lot of log lines that are simply
This PR adds an extra
debug!()call to the error handler that also prints the URL, to aid in debugging whether it's a missing static file, a misspelled crate, or a drive-by Wordpress attack. This is mainly for my own curiosity, since i want to see if there's a pattern in the amount of 404s we get.