Skip to content

Commit 6cce80b

Browse files
Merge pull request #282 from spk/show-dev-deps
Show dev/build dependencies info on menu and detail
2 parents cee3f82 + 5f9aa46 commit 6cce80b

File tree

4 files changed

+29
-6
lines changed

4 files changed

+29
-6
lines changed

src/db/add_package.rs

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ use std::path::{Path, PathBuf};
1010
use std::fs;
1111

1212
use cargo::core::{Package, TargetKind};
13+
use cargo::core::dependency::Kind;
1314
use rustc_serialize::json::{Json, ToJson};
1415
use slug::slugify;
1516
use reqwest::Client;
@@ -208,13 +209,18 @@ fn initialize_package_in_database(conn: &Connection, pkg: &Package) -> Result<i3
208209

209210

210211

211-
/// Convert dependencies into Vec<(String, String)>
212-
fn convert_dependencies(pkg: &Package) -> Vec<(String, String)> {
213-
let mut dependencies: Vec<(String, String)> = Vec::new();
212+
/// Convert dependencies into Vec<(String, String, String)>
213+
fn convert_dependencies(pkg: &Package) -> Vec<(String, String, String)> {
214+
let mut dependencies: Vec<(String, String, String)> = Vec::new();
214215
for dependency in pkg.manifest().dependencies() {
215216
let name = dependency.package_name().to_string();
216217
let version = format!("{}", dependency.version_req());
217-
dependencies.push((name, version));
218+
let kind = match dependency.kind() {
219+
Kind::Normal => "normal",
220+
Kind::Development => "dev",
221+
Kind::Build => "build",
222+
};
223+
dependencies.push((name, version, kind.to_string()));
218224
}
219225
dependencies
220226
}

templates/crate_details.hbs

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,13 @@
2727
<div class="pure-menu pure-menu-scrollable sub-menu">
2828
<ul class="pure-menu-list">
2929
{{#each dependencies}}
30-
<li class="pure-menu-item"><a href="/crate/{{this.[0]}}/{{this.[1]}}" class="pure-menu-link">{{this.[0]}} {{this.[1]}}</a></li>
30+
<li class="pure-menu-item">
31+
<a href="/crate/{{this.[0]}}/{{this.[1]}}"
32+
class="pure-menu-link">
33+
{{this.[0]}} {{this.[1]}}
34+
<i class="dependencies {{this.[2]}}">{{this.[2]}}</i>
35+
</a>
36+
</li>
3137
{{/each}}
3238
</ul>
3339
</div>

templates/navigation_rustdoc.hbs

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,13 @@
5454
<div class="pure-menu pure-menu-scrollable sub-menu">
5555
<ul class="pure-menu-list">
5656
{{#each dependencies}}
57-
<li class="pure-menu-item"><a href="/{{this.[0]}}/{{this.[1]}}" class="pure-menu-link">{{this.[0]}} {{this.[1]}}</a></li>
57+
<li class="pure-menu-item">
58+
<a href="/{{this.[0]}}/{{this.[1]}}"
59+
class="pure-menu-link">
60+
{{this.[0]}} {{this.[1]}}
61+
<i class="dependencies this.[2]">{{this.[2]}}</i>
62+
</a>
63+
</li>
5864
{{/each}}
5965
</ul>
6066
</div>

templates/style.scss

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -726,3 +726,8 @@ footer {
726726
background-color: inherit;
727727
}
728728
}
729+
730+
i.dependencies.normal {
731+
visibility: hidden;
732+
display: none;
733+
}

0 commit comments

Comments
 (0)