add tests for redirects

Author: jyn514

src/test/fakes.rs

@@ -14,7 +14,7 @@ pub(crate) struct FakeRelease<'a> {
     /// name, content
     rustdoc_files: Vec<(&'a str, &'a [u8])>,
     doc_targets: Vec<String>,
-    default_target: Option<String>,
+    default_target: Option<&'a str>,
     cratesio_data: CratesIoData,
     has_docs: bool,
     has_examples: bool,
@@ -90,16 +90,28 @@ impl<'a> FakeRelease<'a> {
         self
     }
 
+    pub(crate) fn default_target(mut self, target: &'a str) -> Self {
+        self.default_target = Some(target);
+        self
+    }
+
     pub(crate) fn create(self) -> Result<i32, Error> {
+        use std::fs;
+        use std::path::Path;
+
         let tempdir = tempdir::TempDir::new("docs.rs-fake")?;
 
         let upload_files = |prefix: &str, files: &[(&str, &[u8])]| {
             let path_prefix = tempdir.path().join(prefix);
-            std::fs::create_dir(&path_prefix)?;
+            fs::create_dir(&path_prefix)?;
 
             for (path, data) in files {
+                // allow `src/main.rs`
+                if let Some(parent) = Path::new(path).parent() {
+                    fs::create_dir_all(path_prefix.join(parent))?;
+                }
                 let file = path_prefix.join(&path);
-                std::fs::write(file, data)?;
+                fs::write(file, data)?;
             }
 
             let prefix = format!("{}/{}/{}", prefix, self.package.name, self.package.version);
@@ -116,7 +128,7 @@ impl<'a> FakeRelease<'a> {
             &self.package,
             tempdir.path(),
             &self.build_result,
-            self.default_target.as_deref().unwrap_or("x86_64-unknown-linux-gnu"),
+            self.default_target.unwrap_or("x86_64-unknown-linux-gnu"),
             Some(source_meta),
             self.doc_targets,
             &self.cratesio_data,

src/test/mod.rs

@@ -37,6 +37,20 @@ pub(crate) fn assert_success(path: &str, web: &TestFrontend) -> Result<(), Error
     Ok(())
 }
 
+/// Make sure that a URL redirects to a specific page
+pub(crate) fn assert_redirect(path: &str, expected_target: &str, web: &TestFrontend) -> Result<(), Error> {
+    let response = web.get(path).send()?;
+    let status = response.status();
+    // Reqwest follows redirects
+    assert!(status.is_success(), "failed to GET {}: {}", path, status);
+
+    let redirect_target = response.url().path();
+    assert!(redirect_target == expected_target,
+            "{}: expected redirect to {}, got redirect to {}",
+            path, expected_target, redirect_target);
+    Ok(())
+}
+
 pub(crate) struct TestEnvironment {
     db: OnceCell<TestDatabase>,
     frontend: OnceCell<TestFrontend>,

src/web/rustdoc.rs

@@ -453,4 +453,38 @@ mod test {
             Ok(())
         });
     }
+    #[test]
+    fn default_target_redirects_to_base() {
+        wrapper(|env| {
+            let db = env.db();
+            db.fake_release()
+              .name("dummy").version("0.1.0")
+              .rustdoc_file("dummy/index.html", b"some content")
+              .create()?;
+
+            let web = env.frontend();
+            // no explicit default-target
+            let base = "/dummy/0.1.0/dummy/";
+            assert_success(base, web)?;
+            assert_redirect("/dummy/0.1.0/x86_64-unknown-linux-gnu/dummy/", base, web)?;
+
+            // set an explicit target that requires cross-compile
+            let target = "x86_64-pc-windows-msvc";
+            db.fake_release().name("dummy").version("0.2.0")
+              .rustdoc_file("dummy/index.html", b"some content")
+              .default_target(target).create()?;
+            let base = "/dummy/0.2.0/dummy/";
+            assert_success(base, web)?;
+            assert_redirect("/dummy/0.2.0/x86_64-pc-windows-msvc/dummy/", base, web)?;
+
+            // set an explicit target without cross-compile
+            let target = "x86_64-unknown-linux-gnu";
+            db.fake_release().name("dummy").version("0.3.0")
+              .rustdoc_file("dummy/index.html", b"some content")
+              .default_target(target).create()?;
+            let base = "/dummy/0.3.0/dummy/";
+            assert_success(base, web)?;
+            assert_redirect("/dummy/0.3.0/x86_64-unknown-linux-gnu/dummy/", base, web)
+        });
+    }
 }