Skip to content

Commit ec834ae

Browse files
authored
Merge pull request #10095 from Turbo87/outdated-comments
Remove outdated code comments
2 parents 8b73b26 + 59f681d commit ec834ae

File tree

2 files changed

+0
-6
lines changed

2 files changed

+0
-6
lines changed

src/controllers/krate/publish.rs

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -52,10 +52,6 @@ const MAX_DESCRIPTION_LENGTH: usize = 1000;
5252
/// Handles the `PUT /crates/new` route.
5353
/// Used by `cargo publish` to publish a new crate or to publish a new version of an
5454
/// existing crate.
55-
///
56-
/// Currently blocks the HTTP thread, perhaps some function calls can spawn new
57-
/// threads and return completion or error through other methods a `cargo publish
58-
/// --status` command, via crates.io's front end, or email.
5955
pub async fn publish(app: AppState, req: Parts, body: Body) -> AppResult<Json<GoodCrate>> {
6056
let stream = body.into_data_stream();
6157
let stream = stream.map_err(|err| std::io::Error::new(std::io::ErrorKind::Other, err));

src/worker/jobs/send_publish_notifications.rs

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -66,8 +66,6 @@ impl BackgroundJob for SendPublishNotificationsJob {
6666
return Ok(());
6767
}
6868

69-
// Sending emails is currently a blocking operation, so we have to use
70-
// `spawn_blocking()` to run it in a separate thread.
7169
let mut results = Vec::with_capacity(recipients.len());
7270

7371
for (ref recipient, email_address) in recipients {

0 commit comments

Comments
 (0)