Merge pull request #8378 from rust-lang/renovate/cargo-manifest-0.x

Update Rust crate cargo-manifest to v0.14.0

Author: Turbo87

Cargo.lock

@@ -57,7 +57,7 @@ axum = { version = "=0.7.5", features = ["macros", "matched-path"] }
 axum-extra = { version = "=0.9.3", features = ["cookie-signed", "typed-header"] }
 base64 = "=0.22.1"
 bigdecimal = { version = "=0.4.3", features = ["serde"] }
-cargo-manifest = "=0.13.0"
+cargo-manifest = "=0.14.0"
 crates_io_cdn_logs = { path = "crates/crates_io_cdn_logs" }
 crates_io_env_vars = { path = "crates/crates_io_env_vars" }
 crates_io_github = { path = "crates/crates_io_github" }

Cargo.toml

@@ -11,7 +11,7 @@ workspace = true
 builder = []
 
 [dependencies]
-cargo-manifest = "=0.13.0"
+cargo-manifest = "=0.14.0"
 flate2 = "=1.0.30"
 serde = { version = "=1.0.203", features = ["derive"] }
 serde_json = "=1.0.117"

crates/crates_io_tarball/Cargo.toml

@@ -24,11 +24,17 @@ pub fn validate_manifest(manifest: &Manifest) -> Result<(), Error> {
 }
 
 pub fn validate_package(package: &Package) -> Result<(), Error> {
+    // Check that the `version` field exists in the package table.
+    let version = package
+        .version
+        .as_ref()
+        .ok_or(Error::Other("missing field `version`".to_string()))?;
+
     // These checks ensure that package field workspace inheritance has been
     // normalized by cargo before publishing.
     if package.edition.is_inherited()
         || package.rust_version.is_inherited()
-        || package.version.is_inherited()
+        || version.is_inherited()
         || package.authors.is_inherited()
         || package.description.is_inherited()
         || package.homepage.is_inherited()

crates/crates_io_tarball/src/manifest.rs

@@ -1,11 +1,11 @@
 ---
 source: src/tests/krate/publish/manifest.rs
-expression: response.into_json()
+expression: response.json()
 ---
 {
   "errors": [
     {
-      "detail": "failed to parse `Cargo.toml` manifest file\n\nTOML parse error at line 1, column 1\n  |\n1 | [package]\n  | ^^^^^^^^^\nmissing field `version`\n"
+      "detail": "failed to parse `Cargo.toml` manifest file\n\nmissing field `version`"
     }
   ]
 }