Auto merge of #2043 - Turbo87:eslint, r=jtgeibel

ESLint: Enable disabled rules

... and instead only disable specific cases using `eslint-disable-next-line` comments

Resolves #2042

r? @jtgeibel

Author: bors

.eslintrc.js

@@ -11,9 +11,6 @@ module.exports = {
   },
   rules: {
     'prettier/prettier': 'error',
-    'ember/no-observers': 'warn',
-    'ember/no-new-mixins': 'warn',
-    'ember/require-return-from-computed': 'warn',
   },
   overrides: [
     // node files

app/components/badge-maintenance.js

@@ -12,6 +12,7 @@ export default Component.extend({
     return this.get('badge.attributes.status') === 'none' || !this.get('badge.attributes.status');
   }),
   status: alias('badge.attributes.status'),
+  // eslint-disable-next-line ember/require-return-from-computed
   color: computed('badge', function() {
     switch (this.get('badge.attributes.status')) {
       case 'actively-developed':

app/controllers/crate/version.js

@@ -173,6 +173,7 @@ export default Controller.extend({
     },
   },
 
+  // eslint-disable-next-line ember/no-observers
   report: observer('crate.readme', function() {
     if (typeof document === 'undefined') {
       return;

app/mixins/authenticated-route.js

@@ -1,6 +1,7 @@
 import Mixin from '@ember/object/mixin';
 import { inject as service } from '@ember/service';
 
+// eslint-disable-next-line ember/no-new-mixins
 export default Mixin.create({
   flashMessages: service(),
   session: service(),

app/mixins/pagination.js

@@ -4,6 +4,7 @@ import { computed } from '@ember/object';
 
 const VIEWABLE_PAGES = 9;
 
+// eslint-disable-next-line ember/no-new-mixins
 export default Mixin.create({
   // Gives page numbers to the surrounding 9 pages.
   pages: computed('currentPage', 'availablePages', function() {

app/mixins/rl-dropdown-component.js

@@ -4,6 +4,7 @@ import { on } from '@ember/object/evented';
 import { bind, later } from '@ember/runloop';
 import $ from 'jquery';
 
+// eslint-disable-next-line ember/no-new-mixins
 export default Mixin.create({
   init() {
     this._super(...arguments);
@@ -49,6 +50,7 @@ export default Mixin.create({
 
   manageClosingEvents: on(
     'didInsertElement',
+    // eslint-disable-next-line ember/no-observers
     observer('dropdownExpanded', function() {
       let namespace = this.closingEventNamespace;
       let clickEventName = `click.${namespace}`;

app/routes/crate/version.js

@@ -11,6 +11,7 @@ export default Route.extend({
 
   flashMessages: service(),
 
+  // eslint-disable-next-line ember/no-observers
   refreshAfterLogin: observer('session.isLoggedIn', function() {
     this.refresh();
   }),

tests/unit/mixins/pagination-test.js

@@ -6,6 +6,7 @@ import PaginationMixin from '../../../mixins/pagination';
 module('Unit | Mixin | pagination', function() {
   // Replace this with your real tests.
   test('it works', function(assert) {
+    // eslint-disable-next-line ember/no-new-mixins
     let PaginationObject = EmberObject.extend(PaginationMixin);
     let subject = PaginationObject.create();
     assert.ok(subject);