background_jobs: Remove unused UpdateCrateIndex job

This has been replaced by the two `SyncToGit/SparseIndex` jobs

Author: Turbo87

src/background_jobs.rs

@@ -20,7 +20,6 @@ pub enum Job {
     SquashIndex,
     SyncToGitIndex(SyncToIndexJob),
     SyncToSparseIndex(SyncToIndexJob),
-    UpdateCrateIndex(UpdateCrateIndexJob),
     UpdateDownloads,
 }
 
@@ -46,7 +45,6 @@ impl Job {
     const SQUASH_INDEX: &str = "squash_index";
     const SYNC_TO_GIT_INDEX: &str = "sync_to_git_index";
     const SYNC_TO_SPARSE_INDEX: &str = "sync_to_sparse_index";
-    const UPDATE_CRATE_INDEX: &str = "update_crate_index";
     const UPDATE_DOWNLOADS: &str = "update_downloads";
 
     pub fn enqueue_sync_to_index<T: ToString>(
@@ -121,10 +119,6 @@ impl Job {
         })
     }
 
-    pub fn update_crate_index(crate_name: String) -> Self {
-        Self::UpdateCrateIndex(UpdateCrateIndexJob { crate_name })
-    }
-
     pub fn update_downloads() -> Self {
         Self::UpdateDownloads
     }
@@ -138,7 +132,6 @@ impl Job {
             Job::SquashIndex => Self::SQUASH_INDEX,
             Job::SyncToGitIndex(_) => Self::SYNC_TO_GIT_INDEX,
             Job::SyncToSparseIndex(_) => Self::SYNC_TO_SPARSE_INDEX,
-            Job::UpdateCrateIndex(_) => Self::UPDATE_CRATE_INDEX,
             Job::UpdateDownloads => Self::UPDATE_DOWNLOADS,
         }
     }
@@ -152,7 +145,6 @@ impl Job {
             Job::SquashIndex => Ok(serde_json::Value::Null),
             Job::SyncToGitIndex(inner) => serde_json::to_value(inner),
             Job::SyncToSparseIndex(inner) => serde_json::to_value(inner),
-            Job::UpdateCrateIndex(inner) => serde_json::to_value(inner),
             Job::UpdateDownloads => Ok(serde_json::Value::Null),
         }
     }
@@ -180,7 +172,6 @@ impl Job {
             Self::SQUASH_INDEX => Job::SquashIndex,
             Self::SYNC_TO_GIT_INDEX => Job::SyncToGitIndex(from_value(value)?),
             Self::SYNC_TO_SPARSE_INDEX => Job::SyncToSparseIndex(from_value(value)?),
-            Self::UPDATE_CRATE_INDEX => Job::UpdateCrateIndex(from_value(value)?),
             Self::UPDATE_DOWNLOADS => Job::UpdateDownloads,
             job_type => Err(PerformError::from(format!("Unknown job type {job_type}")))?,
         })
@@ -201,7 +192,6 @@ impl Job {
             }
             Job::DumpDb(args) => worker::perform_dump_db(env, args.database_url, args.target_name),
             Job::SquashIndex => worker::perform_index_squash(env),
-            Job::UpdateCrateIndex(args) => worker::perform_index_sync_to_http(env, args.crate_name),
             Job::NormalizeIndex(args) => worker::perform_normalize_index(env, args),
             Job::RenderAndUploadReadme(args) => worker::perform_render_and_upload_readme(
                 conn,

src/worker/git.rs

@@ -9,34 +9,6 @@ use std::fs::{self, File};
 use std::io::{BufRead, BufReader, ErrorKind, Write};
 use std::process::Command;
 
-#[instrument(skip(env))]
-pub fn perform_index_sync_to_http(
-    env: &Environment,
-    crate_name: String,
-) -> Result<(), PerformError> {
-    info!("Syncing git index to HTTP-based index");
-
-    let repo = env.lock_index()?;
-    let dst = repo.index_file(&crate_name);
-
-    let contents = match fs::read_to_string(dst) {
-        Ok(contents) => Some(contents),
-        Err(e) if e.kind() == ErrorKind::NotFound => None,
-        Err(e) => return Err(e.into()),
-    };
-
-    env.uploader
-        .sync_index(env.http_client(), &crate_name, contents)?;
-
-    if let Some(cloudfront) = env.cloudfront() {
-        let path = Repository::relative_index_file_for_url(&crate_name);
-        info!(%path, "Invalidating index file on CloudFront");
-        cloudfront.invalidate(env.http_client(), &path)?;
-    }
-
-    Ok(())
-}
-
 /// Regenerates or removes an index file for a single crate
 #[instrument(skip_all, fields(krate.name = ?krate))]
 pub fn sync_to_git_index(

src/worker/mod.rs

@@ -13,8 +13,7 @@ mod update_downloads;
 pub(crate) use daily_db_maintenance::perform_daily_db_maintenance;
 pub(crate) use dump_db::perform_dump_db;
 pub(crate) use git::{
-    perform_index_squash, perform_index_sync_to_http, perform_normalize_index, sync_to_git_index,
-    sync_to_sparse_index,
+    perform_index_squash, perform_normalize_index, sync_to_git_index, sync_to_sparse_index,
 };
 pub(crate) use readmes::perform_render_and_upload_readme;
 pub(crate) use update_downloads::perform_update_downloads;