processSearchQuery: Remove support for keywords: filter

as discussed in the team meeting

Author: Turbo87

app/utils/search.js

@@ -1,9 +1,8 @@
 const CATEGORY_PREFIX = 'category:';
 const KEYWORD_PREFIX = 'keyword:';
-const KEYWORDS_PREFIX = 'keywords:';
 
 /**
- * Process a search query string and extract filters like `keywords:`.
+ * Process a search query string and extract filters like `keyword:`.
  *
  * @param {string} query
  * @return {{ q: string, keyword?: string, all_keywords?: string, category?: string }}
@@ -25,12 +24,6 @@ export function processSearchQuery(query) {
       if (value) {
         keywords.push(value);
       }
-    } else if (token.startsWith(KEYWORDS_PREFIX)) {
-      keywords = token
-        .slice(KEYWORDS_PREFIX.length)
-        .split(',')
-        .map(it => it.trim())
-        .filter(Boolean);
     } else {
       queries.push(token);
     }

tests/acceptance/search-test.js

@@ -207,7 +207,7 @@ module('Acceptance | search', function (hooks) {
       return { crates: [], meta: { total: 0 } };
     });
 
-    await visit('/search?q=rust keywords:fire,ball&page=3&per_page=15&sort=new');
+    await visit('/search?q=rust keyword:fire keyword:ball&page=3&per_page=15&sort=new');
     assert.verifySteps(['/api/v1/crates']);
   });
 

tests/utils/search-test.js

@@ -6,16 +6,14 @@ module('processSearchQuery()', function () {
   const TESTS = [
     ['foo', { q: 'foo' }],
     ['  foo    bar     ', { q: 'foo bar' }],
-    ['foo keywords:bar', { q: 'foo', keyword: 'bar' }],
-    ['foo keywords:', { q: 'foo' }],
-    ['keywords:bar foo', { q: 'foo', keyword: 'bar' }],
-    ['foo \t   keywords:bar    baz', { q: 'foo baz', keyword: 'bar' }],
-    ['foo keywords:bar,baz', { q: 'foo', all_keywords: 'bar baz' }],
-    ['foo keywords:bar keywords:baz', { q: 'foo', keyword: 'baz' }],
+    ['foo keyword:bar', { q: 'foo', keyword: 'bar' }],
+    ['foo keyword:', { q: 'foo' }],
+    ['keyword:bar foo', { q: 'foo', keyword: 'bar' }],
+    ['foo \t   keyword:bar    baz', { q: 'foo baz', keyword: 'bar' }],
     ['foo keyword:bar keyword:baz', { q: 'foo', all_keywords: 'bar baz' }],
     ['foo category:', { q: 'foo' }],
     ['foo category:no-std', { q: 'foo', category: 'no-std' }],
-    ['foo category:no-std keywords:bar,baz', { q: 'foo', all_keywords: 'bar baz', category: 'no-std' }],
+    ['foo category:no-std keyword:bar keyword:baz', { q: 'foo', all_keywords: 'bar baz', category: 'no-std' }],
   ];
 
   for (let [input, expectation] of TESTS) {