jobs/delete_crate: Ensure job fails if files failed to delete

This ensures that the background job will be retried if a deletion was unsuccessful.

Author: Turbo87

src/worker/jobs/delete_crate.rs

@@ -1,5 +1,6 @@
 use crate::storage::FeedId;
 use crate::worker::Environment;
+use anyhow::Context;
 use crates_io_worker::BackgroundJob;
 use std::sync::Arc;
 
@@ -24,20 +25,17 @@ impl BackgroundJob for DeleteCrateFromStorage {
         let name = &self.name;
 
         info!("{name}: Deleting crate files from S3…");
-        if let Err(error) = ctx.storage.delete_all_crate_files(name).await {
-            warn!("{name}: Failed to delete crate files from S3: {error}");
-        }
+        let result = ctx.storage.delete_all_crate_files(name).await;
+        result.context("Failed to delete crate files from S3")?;
 
         info!("{name}: Deleting readme files from S3…");
-        if let Err(error) = ctx.storage.delete_all_readmes(name).await {
-            warn!("{name}: Failed to delete readme files from S3: {error}");
-        }
+        let result = ctx.storage.delete_all_readmes(name).await;
+        result.context("Failed to delete readme files from S3")?;
 
         info!("{name}: Deleting RSS feed from S3…");
         let feed_id = FeedId::Crate { name };
-        if let Err(error) = ctx.storage.delete_feed(&feed_id).await {
-            warn!("{name}: Failed to delete RSS feed from S3: {error}");
-        }
+        let result = ctx.storage.delete_feed(&feed_id).await;
+        result.context("Failed to delete RSS feed from S3")?;
 
         info!("{name}: Successfully deleted crate from S3");
         Ok(())