-
Notifications
You must be signed in to change notification settings - Fork 187
Join global_asm macro invocations #322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Join global_asm macro invocations #322
Conversation
Fixes rust-embedded#321 Co-authored-by: Dario Nieuwenhuis <[email protected]>
0c2a208 to
e320adc
Compare
rmsyn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor clippy fix:
https://github.com/rust-embedded/riscv/actions/runs/16010020609/job/45165521521?pr=322
Otherwise, LGTM.
Bumping the MSRV to make Nightly Clippy happy seems too much. Currently, Nightly builds and checks are marked as experimental, and it is OK to merge PRs with reasonable failures in Nightly. I'm CC'ing @gibbz00 , as he mentioned that it might be possible to "relax" a bit Nightly clippy requirements |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you.
There are a few core::arch::global_asm! calls in the macros and at the end of asm.rs, but all of these blobs specify a section, so I guess it is not UB? We don't need them to be in a specific memory location or order, as long as they are in their corresponding section. In this case, the linker will do the hard work.
riscv/.github/workflows/clippy.yaml Line 10 in cdae64a
(Concise lint group explanation here: https://github.com/rust-lang/rust-clippy?tab=readme-ov-file#clippy) That is, the general lint policy should IMO be;
|
afa79b5
|
Thanks for discussing the clippy warnings. I didn't have time to care about them yesterday. I agree that it doesn't make sense chasing every single new warning on nightly immediately. |
Fixes #321
I intentionally didn't update the indentation, for two reasons:
If you'd prefer some certain way of indenting the conditional blocks inside the
cfg_global_asm!call, I'll happily update the pull request.