Correct bench feature gating #519
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We currently have the feature gating incorrect in a few places, `thread_rng` requires "rand-std".
Kixunil
requested changes
Nov 17, 2022
|
|
||
| #[bench] | ||
| #[cfg(any(feature = "alloc", feature = "std"))] | ||
| #[cfg(all(feature = "std", feature = "rnd-std"))] |
Collaborator
There was a problem hiding this comment.
rand-std should imply std so just rand-std should be sufficient but currently it's not the case - this is a bug. Also you seem to be missing a, so if you're going to fix it anyway might as well add std to the Cargo.toml list.
Member
Author
There was a problem hiding this comment.
Lol, this broken change makes the PR title amusing :)
Member
Author
|
Superseded by #520 |
apoelstra
added a commit
to rust-bitcoin/rust-bitcoin
that referenced
this pull request
Dec 30, 2022
941083e Remove rand-std dev-dependency from secp256k1 (Tobin C. Harding) f71335f Add rand-std feature (Tobin C. Harding) Pull request description: This PR uncovered incorrect feature gating in `secp256k1`, fixed in rust-bitcoin/rust-secp256k1#519 Currently we enable "secp256k1/rand-std" in the "rand" feature, this is incorrect because it means "rand" implies "std" which it does not. Add a "rand-std" feature that turns on "seck256k1/rand-std" and make the "rand" feature turn on "seck256k1/rand". Fix: #1384 ACKs for top commit: sanket1729: ACK 941083e apoelstra: ACK 941083e Tree-SHA512: e1d12196766c2b3082b488fe7d0c03a865ebbfc70ffa6f128c57074df14da71e56c31ea92982991d376ac62fa86c6639049ce17aac93613b523ddcc99677c269
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently have the feature gating incorrect in a few places,
thread_rngrequires "rand-std".Found while doing rust-bitcoin/rust-bitcoin#1387