Implement is_empty on TokenIter
#398
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clippy emits:
```
warning: struct `TokenIter` has a public `len` method, but no `is_empty` method
--> src/miniscript/lex.rs:102:5
|
102 | pub fn len(&self) -> usize {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= note: `#[warn(clippy::len_without_is_empty)]` on by default
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty
```
Iterators typically do not implement `is_empty` because there is often
no way for an iterator to know if there are more items without calling
`next`, however we use a `Vec` under the hood so `is_empty` is cheap.
apoelstra
reviewed
May 10, 2022
heap-coder
added a commit
to heap-coder/rust-miniscript
that referenced
this pull request
Sep 27, 2025
…nIter`
cb51a5b3dbf51dce4474a73d54f35878f551c754 Implement is_empty on TokenIter (Tobin C. Harding)
Pull request description:
Clippy emits:
```
warning: struct `TokenIter` has a public `len` method, but no `is_empty` method
--> src/miniscript/lex.rs:102:5
|
102 | pub fn len(&self) -> usize {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= note: `#[warn(clippy::len_without_is_empty)]` on by default
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty
```
Iterators typically do not implement `is_empty` because there is often no way for an iterator to know if there are more items without calling `next`, however we use a `Vec` under the hood so `is_empty` is cheap.
Implement `is_empty` on the `TokenIter` struct.
Top commit has no ACKs.
Tree-SHA512: b0b832ac9457b9eef725b4589198212d90ea66faa4788792551da31a7601b928edbd7658f33862ed8210478cc4512af4ebb35be1cddf9d66ac67f6222f282a3e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clippy emits:
Iterators typically do not implement
is_emptybecause there is often no way for an iterator to know if there are more items without callingnext, however we use aVecunder the hood sois_emptyis cheap.Implement
is_emptyon theTokenIterstruct.