Bitcoin 0.28.0-rc.2

[dr-orlovsky]

This is a draft API adopting new version of rust-bitcoin 0.28.0-rc.2

[sanket1729]

Note that this would need to be a single commit to make sure all commits compile and test. Unfortunately, there is no clean way to have atomic commits here.

What I typically tend to do in these cases is to have separate branches with 2 PRs, one with atomic commits and one with a single commit. And then locally check that the diff between the two is null. This is not required for this case because the diff is small and I can review it in single commit.

[dr-orlovsky]

@sanket1729 working on update

[sanket1729]

@dr-orlovsky: One other thing that needs to be fixed here:

rust-miniscript/src/psbt/finalizer.rs

Line 119 in 1f9affc

pub(super) fn prevouts<'a>(psbt: &'a Psbt) -> Result<Vec<bitcoin::TxOut>, super::Error> {

Should return &bitcoin::TxOut instead of bitcoin::Txout.

Also, the commit message should be 0.28.0-rc.2 instead of 0.27.0-rc.2.

[dr-orlovsky]

@sanket1729 will fix both of the issues once bitcoin gets released and will do a final update to use released version

[apoelstra]

Ok, rust-bitcoin rc2 is out

[dr-orlovsky]

Updating this one

[dr-orlovsky]

@apoelstra @sanket1729 ready for the review, CI is fixed

[sanket1729]

tACK 08ed922. The commit message still says 0.27, but I can live with it

[dr-orlovsky]

ouh, sorry for forgetting about that message :(

[sanket1729]

Tagged and published.