miniscript/types: check that timelock values aren't too large #246
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanket1729
reviewed
Jun 16, 2021
This changes the ZeroTime error into an InvalidTime error and checks that the disabling bit (most significant one) isn't set in the timelock value. We could also check the value is minimal, using the mask. Signed-off-by: Antoine Poinsot <[email protected]>
sanket1729
approved these changes
Jun 16, 2021
Member
sanket1729
left a comment
sanket1729
left a comment
There was a problem hiding this comment.
utACK a3dd9fe . Thanks for doing this.
apoelstra
approved these changes
Sep 8, 2021
heap-coder
added a commit
to heap-coder/rust-miniscript
that referenced
this pull request
Sep 27, 2025
…timelock values aren't too large
a3dd9fe840c8cdae84e9d586cd9a9d6c195f0092 miniscript/types: check that timelock values aren't too large (Antoine Poinsot)
Pull request description:
Wonder if we should check that the timelock value is minimal too, what do you think?
ACKs for top commit:
sanket1729:
utACK a3dd9fe840c8cdae84e9d586cd9a9d6c195f0092 . Thanks for doing this.
apoelstra:
ACK a3dd9fe840c8cdae84e9d586cd9a9d6c195f0092
Tree-SHA512: 900c4de066581a0aa3137349c75336c30bc2b70239f47d5dab4ce2b1b33fb40428ce27837916767e51c03a1340c3f86cec036825e5da277216b892cbdbfb54a2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wonder if we should check that the timelock value is minimal too, what do you think?