Replace Synchronized annotations by making the lists Synchronized instead of using a normal ArrayList.

Author: ultraviolet-jordan

cache/src/main/kotlin/com/runetopic/cache/store/Js5Store.kt

@@ -7,6 +7,7 @@ import java.io.Closeable
 import java.math.BigInteger
 import java.nio.ByteBuffer
 import java.nio.file.Path
+import java.util.*
 
 /**
  * @author Tyler Telis
@@ -19,14 +20,13 @@ class Js5Store(
     parallel: Boolean = false
 ) : Closeable {
     private var storage = Js5DiskStorage(path, parallel)
-    private val indexes = arrayListOf<Index>()
+    private val indexes = Collections.synchronizedList<Index>(mutableListOf())
 
     init {
         storage.init(this)
         indexes.sortWith(compareBy { it.id })
     }
 
-    @Synchronized
     internal fun addIndex(index: Index) {
         indexes.forEach { i -> require(index.id != i.id) { "Index with Id={${index.id}} already exists." } }
         indexes.add(index)

cache/src/main/kotlin/com/runetopic/cache/store/storage/js5/Js5DiskStorage.kt

@@ -11,6 +11,7 @@ import com.runetopic.cache.store.storage.js5.impl.IdxFile
 import com.runetopic.cryptography.toWhirlpool
 import java.io.FileNotFoundException
 import java.nio.file.Path
+import java.util.*
 import java.util.concurrent.CountDownLatch
 import java.util.concurrent.Executors
 import kotlin.io.path.ExperimentalPathApi
@@ -29,7 +30,7 @@ internal class Js5DiskStorage(
 ) : IStorage {
     private var masterIdxFile: IIdxFile
     private var datFile: IDatFile
-    private var idxFiles: ArrayList<IdxFile> = arrayListOf()
+    private var idxFiles = Collections.synchronizedList<IdxFile>(mutableListOf())
     private val logger = InlineLogger()
 
     init {
@@ -96,7 +97,6 @@ internal class Js5DiskStorage(
         return datFile.readReferenceTable(index.id, getIdxFile(index.id).loadReferenceTable(group.id))
     }
 
-    @Synchronized
     private fun getIdxFile(id: Int): IdxFile {
         idxFiles.find { it.id() == id }?.let { return it }
         return IdxFile(id, Path.of("$path/${Constants.MAIN_FILE_IDX}${id}"))