From 0b39396a75a3a3c8e3cd7e5f8293bf7e1f81bbb5 Mon Sep 17 00:00:00 2001 From: Jean Boussier Date: Sat, 8 Jun 2024 12:09:47 +0200 Subject: [PATCH 1/2] Test on macos-latest But exclude Ruby 2.4 and 2.5 because they aren't supported on macos-arm64. --- .github/workflows/test.yml | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index a4534c8..d52899c 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -13,9 +13,15 @@ jobs: needs: ruby-versions name: build (${{ matrix.ruby }} / ${{ matrix.os }}) strategy: + fail-fast: false matrix: ruby: ${{ fromJson(needs.ruby-versions.outputs.versions) }} - os: [ ubuntu-latest, macos-13 ] + os: [ ubuntu-latest, macos-latest ] + exclude: + - os: macos-latest + ruby: "2.4" + - os: macos-latest + ruby: "2.5" runs-on: ${{ matrix.os }} steps: - uses: actions/checkout@v4 From e2282dfc6c3c2af411115373e025100abd5061cf Mon Sep 17 00:00:00 2001 From: Benoit Daloze Date: Sat, 8 Jun 2024 13:20:53 +0200 Subject: [PATCH 2/2] Test 2.4 & 2.5 on macos-amd64 --- .github/workflows/test.yml | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index d52899c..edede5b 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -17,11 +17,13 @@ jobs: matrix: ruby: ${{ fromJson(needs.ruby-versions.outputs.versions) }} os: [ ubuntu-latest, macos-latest ] + # CRuby < 2.6 does not support macos-arm64, so test those on amd64 instead exclude: - - os: macos-latest - ruby: "2.4" - - os: macos-latest - ruby: "2.5" + - { os: macos-latest, ruby: '2.4' } + - { os: macos-latest, ruby: '2.5' } + include: + - { os: macos-13, ruby: '2.4' } + - { os: macos-13, ruby: '2.5' } runs-on: ${{ matrix.os }} steps: - uses: actions/checkout@v4