-
Notifications
You must be signed in to change notification settings - Fork 83
Speed up loading bigdecimal gem #148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: Nobuyoshi Nakada <[email protected]>
|
I think that we can just stop fat gem support for the performance improvement. |
|
Isn't a binary gem also for mswin? |
We may be able to use a binary gem for *-mingw32 with *-mswin* because it for *-mingw32 uses non versioned And existing binary gems for *-mingw32 aren't installed automatically with *-mswin* Ruby. Because they are different architecture. |
I'm totally fine with either solution.
This may work great so far as everything is working. But it may cause some compilation troubles especially for those who are not very much familiar with compiling things, and so the development team may have to spend some time on shooting such troubles. |
Providing fat gem spends more time than resolving build error problems in my experience (I stopped fat gem support for Ruby-GNOME2 that has Windows users). Normally, build error problems aren't occurred while AppVeyor build is green. Normally, releasing fat gems is forgotten. For example, bigdecimal started fat gem support since 2017 #75 but no fat gems are released: https://rubygems.org/gems/bigdecimal/versions I'm not surprised at this because releasing fat gems is a bother. We need to run more commands ( I think that removing fat gem support will make both users (improving |
Ugh. So sorry about this. I asked nobu to release the gem and I was physically pairing with him, but yeah, we skipped that process... Anyway, I'm now +1 for omitting the fat gem release. Let's see how it goes, and we can switch back to the fat gems anytime if we're seeing unexpected problems. |
|
We don't need to care about major version bump. Because we have never released fat gems for bigdecimal. @mrkn What do you think about removing fat gem support? I think that you don't want to care about Windows. So removing fat gem support seems reasonable to you. |
|
I want to drop fat gem support. |
|
OK. Let's drop fat gem support. @amatsuda Do you want to work on it in this pull request or create another pull request? |
"fat gem" release has never actually been done in the past, and we have no plan to do it in the near future. See GH#148 for the detailed discussion. ruby#148
|
Just made another PR #149 for dropping the whole "fat gem" thing. |
This patch drastically reduces time taken to load the gem in all non-Windows platforms.
Here's a quick benchmark result of requiring the gem before and after this patch on my Mac.
This patch was originally written by @nobu for io-console gem, and I'm just copying the solution to this repo, so please read other repos' PRs for more details.
ruby/psych#406
ruby/io-console#4