From af8cb9936ca2e986e441d02173cb1893d4e62ec4 Mon Sep 17 00:00:00 2001 From: isabel zimmerman Date: Tue, 29 Apr 2025 16:14:38 -0400 Subject: [PATCH 1/3] remove extra / --- pins/boards.py | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/pins/boards.py b/pins/boards.py index 91bfb585..580db588 100644 --- a/pins/boards.py +++ b/pins/boards.py @@ -133,8 +133,7 @@ def pin_meta(self, name, version: str = None) -> Meta: # ensure pin and version exist if not self.fs.exists(self.construct_path([pin_name, version])): raise PinsError( - f"Pin {name} either does not exist, " - f"or is missing version: {version}." + f"Pin {name} either does not exist, or is missing version: {version}." ) selected_version = guess_version(version) @@ -882,7 +881,7 @@ class BoardManual(BaseBoard): >>> import fsspec >>> import os >>> fs = fsspec.filesystem("github", org = "rstudio", repo = "pins-python") - >>> pin_paths = {"df_csv": "df_csv/20220214T163720Z-9bfad/"} + >>> pin_paths = {"df_csv": "df_csv/20220214T163720Z-9bfad"} >>> board = BoardManual("pins/tests/pins-compat", fs, pin_paths=pin_paths) >>> board.pin_list() From 62a069dcf3492db695fb2731891de9f3692e3602 Mon Sep 17 00:00:00 2001 From: isabel zimmerman Date: Wed, 30 Apr 2025 11:39:00 -0400 Subject: [PATCH 2/3] use Path instead of strs for path construction --- pins/boards.py | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/pins/boards.py b/pins/boards.py index 580db588..50b72bee 100644 --- a/pins/boards.py +++ b/pins/boards.py @@ -881,7 +881,7 @@ class BoardManual(BaseBoard): >>> import fsspec >>> import os >>> fs = fsspec.filesystem("github", org = "rstudio", repo = "pins-python") - >>> pin_paths = {"df_csv": "df_csv/20220214T163720Z-9bfad"} + >>> pin_paths = {"df_csv": "df_csv/20220214T163720Z-9bfad/"} >>> board = BoardManual("pins/tests/pins-compat", fs, pin_paths=pin_paths) >>> board.pin_list() @@ -983,8 +983,7 @@ def construct_path(self, elements): return "/".join(pre_components + [pin_path]) elif len(others) == 2: version, meta = others - - return "/".join(pre_components + [stripped, meta]) + return str(Path(*pre_components, stripped, meta)) raise NotImplementedError( f"Unable to construct path from these elements: {elements}" From c6a0dd0e1a6880798bdf0d81817d9018c1a4ff77 Mon Sep 17 00:00:00 2001 From: isabel zimmerman Date: Wed, 30 Apr 2025 12:00:17 -0400 Subject: [PATCH 3/3] update docstring to url --- pins/boards.py | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/pins/boards.py b/pins/boards.py index 50b72bee..70fc8ba4 100644 --- a/pins/boards.py +++ b/pins/boards.py @@ -880,9 +880,10 @@ class BoardManual(BaseBoard): -------- >>> import fsspec >>> import os - >>> fs = fsspec.filesystem("github", org = "rstudio", repo = "pins-python") + >>> fs = fsspec.filesystem("http", block_size=0) >>> pin_paths = {"df_csv": "df_csv/20220214T163720Z-9bfad/"} - >>> board = BoardManual("pins/tests/pins-compat", fs, pin_paths=pin_paths) + >>> url = "https://raw.githubusercontent.com/rstudio/pins-python/main/pins/tests/pins-compat" + >>> board = BoardManual(url, fs, pin_paths=pin_paths) >>> board.pin_list() ['df_csv'] @@ -983,7 +984,7 @@ def construct_path(self, elements): return "/".join(pre_components + [pin_path]) elif len(others) == 2: version, meta = others - return str(Path(*pre_components, stripped, meta)) + return "/".join(pre_components + [stripped, meta]) raise NotImplementedError( f"Unable to construct path from these elements: {elements}"