Skip to content

Conversation

@gadenbuie
Copy link
Member

Fixes #846

Moves nav_panel() out of nav_menu() and make the dropdown menu contain only the links.

I also removed align = "right" from places where it wasn't required (everywhere except page_navbar()).

@gadenbuie gadenbuie marked this pull request as ready for review October 18, 2023 18:02
@gadenbuie gadenbuie requested a review from cpsievert October 18, 2023 18:02
Copy link
Collaborator

@cpsievert cpsievert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@gadenbuie gadenbuie merged commit ac0c298 into main Oct 18, 2023
@gadenbuie gadenbuie deleted the docs/recommended-navset branch October 18, 2023 18:30
schloerke added a commit to posit-dev/py-shiny that referenced this pull request Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Don't use nav_panel() inside nav_menu() in our navset example

3 participants