Skip to content

fix(bs_theme_preview): Don't include dashboard tab for BS < 5 #670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 12, 2023
Merged

fix(bs_theme_preview): Don't include dashboard tab for BS < 5 #670

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion inst/themer-demo/app.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ progressBar <- div(

# This is here for shinycoreci to take advantage of (so we don't need to update a bunch of screenshots)
IS_LEGACY <- as.logical(Sys.getenv("BSLIB_LEGACY_THEMER_APP", FALSE))
if (isTRUE(IS_LEGACY)) {
if (isTRUE(IS_LEGACY) || theme_version(theme) %in% c("3", "4")) {
dashboardTab <- NULL
} else {
dashboardTab <- nav_panel("Dashboard", tipsUI("tips"))
Expand Down