Close #756: Always initialize the sidebar

Author: cpsievert

R/sidebar.R

@@ -227,13 +227,11 @@ layout_sidebar <- function(
   max_height_mobile <- sidebar$max_height_mobile %||%
     if (is.null(height)) "250px" else "50%"
 
-  sidebar_init <- if (!identical(sidebar$open, "always")) TRUE
-
   res <- div(
     class = "bslib-sidebar-layout bslib-mb-spacing",
     class = if (right) "sidebar-right",
     class = if (identical(sidebar$open, "closed")) "sidebar-collapsed",
-    `data-bslib-sidebar-init` = sidebar_init,
+    `data-bslib-sidebar-init` = TRUE,
     `data-bslib-sidebar-open` = sidebar$open,
     `data-bslib-sidebar-border` = if (!is.null(border)) tolower(border),
     `data-bslib-sidebar-border-radius` = if (!is.null(border_radius)) tolower(border_radius),
@@ -320,4 +318,3 @@ sidebar_dependency <- function() {
 sidebar_dependency_sass <- function(theme) {
   component_dependency_sass(theme, "sidebar")
 }
-

inst/components/dist/sidebar/sidebar.js

@@ -89,18 +89,18 @@ class Sidebar {
       ) as HTMLElement,
     } as SidebarComponents;
 
-    if (!this.layout.toggle) {
-      throw new Error("Tried to initialize a non-collapsible sidebar.");
-    }
-
     const sideAccordion = this.layout.sidebar.querySelector(
       ":scope > .sidebar-content > .accordion"
     );
-    if (sideAccordion) sideAccordion.classList.add("accordion-flush");
+    if (sideAccordion) {
+      sideAccordion.classList.add("accordion-flush");
+    }
 
-    this._initEventListeners();
-    this._initSidebarCounters();
-    this._initDesktop();
+    if (this.layout.toggle) {
+      this._initEventListeners();
+      this._initSidebarCounters();
+      this._initDesktop();
+    }
 
     // Start watching the main content area for size changes to ensure Shiny
     // outputs resize appropriately during sidebar transitions.