From bce49d804fccc67f10c600fe492d378c1d4775eb Mon Sep 17 00:00:00 2001 From: Phil Pirozhkov Date: Thu, 30 Dec 2021 15:52:44 +0300 Subject: [PATCH] Stop using the deceiving continue-on-error Build jobs appear as green even though they actually fail. A better approach is to mark jobs as "required" in branch protection. This way failed jobs are red, but this doesn't prevent the PR from being merged upon at maintainers' discretion. --- .github/workflows/ci.yml | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index af4080bcc..8f650aca2 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -18,25 +18,20 @@ jobs: include: # Edge Rails (7.1) builds >= 2.7 - ruby: '3.0' - allow_failure: true env: RAILS_VERSION: 'main' - ruby: 2.7 - allow_failure: true env: RAILS_VERSION: 'main' # Rails 7.0 builds >= 2.7 - ruby: 3.1 - allow_failure: true env: RAILS_VERSION: '~> 7.0.0' - ruby: '3.0' - allow_failure: true env: RAILS_VERSION: '~> 7.0.0' - ruby: 2.7 - allow_failure: true env: RAILS_VERSION: '~> 7.0.0' @@ -113,4 +108,4 @@ jobs: - run: script/clone_all_rspec_repos - run: bundle install --binstubs - run: script/run_build - continue-on-error: ${{ matrix.allow_failure || false }} + continue-on-error: false