Merge pull request #2524 from rspec/revive-rails5.2-build-on-ruby-2.2

Disallow failures for passing builds

Author: JonRowe

.github/workflows/ci.yml

@@ -28,7 +28,6 @@ jobs:
 
          # Rails 6.1 builds >= 2.5
          - ruby: 3.0
-           allow_failure: true
            env:
              RAILS_VERSION: '~> 6.1.0'
          - ruby: 2.7
@@ -68,7 +67,6 @@ jobs:
            env:
              RAILS_VERSION: '~> 5.2.0'
          - ruby: 2.2.10
-           allow_failure: true
            env:
              RAILS_VERSION: '~> 5.2.0'
          - ruby: 2.2.10

spec/rspec/rails/example/view_example_group_spec.rb

@@ -239,19 +239,8 @@ def _view; end # Stub method
         expect(view_spec.view).to eq(view)
       end
 
-      if RUBY_VERSION <= "2.3.0" && ENV["RAILS_VERSION"] !~ /stable/ && ::Rails.version.to_f == 5.2
-        pending_only_on_ruby_22_rails_52 = """
-          Rails 5.2.4.2 has a syntax error in ActionDispatch::Request::Session.
-          (A &. usage which does not work in 2.2.10)
-          It has been fixed but not released, this spec will not pass until that
-          has been released.
-        """
-      else
-        pending_only_on_ruby_22_rails_52 = false
-      end
-
       # Regression test from rspec/rspec-rails#833
-      it 'is accessible to configuration-level hooks', pending: pending_only_on_ruby_22_rails_52 do
+      it 'is accessible to configuration-level hooks' do
         run_count = 0
         RSpec.configuration.before(:each, type: :view) do
           # `view` is provided from the view example type, and serves to