This repository was archived by the owner on Nov 30, 2024. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 752
Make inspection value for Example::Procsy be the same as class name of it #2915
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dfd7bd4 to
85b7eb7
Compare
pirj
approved these changes
Oct 16, 2021
Member
pirj
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Originally introduced in #1620
Surely, providing a correct class name makes it easier when debug goes beyond the application code.
Thank you!
Contributor
Author
Member
|
Thanks! |
JonRowe
added a commit
that referenced
this pull request
Oct 17, 2021
Make inspection value for Example::Procsy be the same as class name of it
JonRowe
added a commit
that referenced
this pull request
Oct 17, 2021
Make inspection value for Example::Procsy be the same as class name of it
yujinakayama
pushed a commit
to yujinakayama/rspec-monorepo
that referenced
this pull request
Oct 19, 2021
…procsy Make inspection value for Example::Procsy be the same as class name of it --- This commit was imported from rspec/rspec-core@f20072a.
yujinakayama
pushed a commit
to yujinakayama/rspec-monorepo
that referenced
this pull request
Oct 19, 2021
This commit was imported from rspec/rspec-core@d57c371.
yujinakayama
pushed a commit
to yujinakayama/rspec-monorepo
that referenced
this pull request
Oct 19, 2021
…procsy Make inspection value for Example::Procsy be the same as class name of it --- This commit was imported from rspec/rspec-core@c18fc29.
yujinakayama
pushed a commit
to yujinakayama/rspec-monorepo
that referenced
this pull request
Oct 19, 2021
This commit was imported from rspec/rspec-core@18968e0.
yujinakayama
pushed a commit
to yujinakayama/rspec-monorepo
that referenced
this pull request
Oct 19, 2021
…procsy Make inspection value for Example::Procsy be the same as class name of it --- This commit was imported from rspec/rspec-core@3974015.
yujinakayama
pushed a commit
to yujinakayama/rspec-monorepo
that referenced
this pull request
Oct 19, 2021
This commit was imported from rspec/rspec-core@b18c455.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found inspect for
Example::Procsya little bit different from it's class name. Actually, I searchedExampleProcsyclass to debug.I think It's better that inspection of instance shows the class name.
In this PR, I update the return value from
ExampleProcsytoExample::Procsy.