Skip to content
This repository was archived by the owner on Nov 30, 2024. It is now read-only.

Conversation

@neko314
Copy link
Contributor

@neko314 neko314 commented Oct 16, 2021

I found inspect for Example::Procsy a little bit different from it's class name. Actually, I searched ExampleProcsy class to debug.
I think It's better that inspection of instance shows the class name.

In this PR, I update the return value from ExampleProcsy to Example::Procsy.

@pirj pirj requested a review from JonRowe October 16, 2021 08:34
Copy link
Member

@pirj pirj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Originally introduced in #1620

Surely, providing a correct class name makes it easier when debug goes beyond the application code.

Thank you!

@neko314
Copy link
Contributor Author

neko314 commented Oct 17, 2021

@pirj
Thanks for your review and approving!

The one of jobs on CI - RSpec CI / Legacy Ruby Builds (JRuby 1.7 1.8 mode) (pull_request) failed. I couldn't make it green by my self. Does it related to #2909 or not?

@JonRowe JonRowe merged commit f20072a into rspec:main Oct 17, 2021
@JonRowe
Copy link
Member

JonRowe commented Oct 17, 2021

Thanks!

JonRowe added a commit that referenced this pull request Oct 17, 2021
JonRowe added a commit that referenced this pull request Oct 17, 2021
Make inspection value for Example::Procsy be the same as class name of it
JonRowe added a commit that referenced this pull request Oct 17, 2021
JonRowe added a commit that referenced this pull request Oct 17, 2021
Make inspection value for Example::Procsy be the same as class name of it
JonRowe added a commit that referenced this pull request Oct 17, 2021
@neko314 neko314 deleted the example_procsy branch October 17, 2021 23:58
yujinakayama pushed a commit to yujinakayama/rspec-monorepo that referenced this pull request Oct 19, 2021
…procsy

Make inspection value for Example::Procsy be the same as class name of it

---
This commit was imported from rspec/rspec-core@f20072a.
yujinakayama pushed a commit to yujinakayama/rspec-monorepo that referenced this pull request Oct 19, 2021
yujinakayama pushed a commit to yujinakayama/rspec-monorepo that referenced this pull request Oct 19, 2021
…procsy

Make inspection value for Example::Procsy be the same as class name of it

---
This commit was imported from rspec/rspec-core@c18fc29.
yujinakayama pushed a commit to yujinakayama/rspec-monorepo that referenced this pull request Oct 19, 2021
yujinakayama pushed a commit to yujinakayama/rspec-monorepo that referenced this pull request Oct 19, 2021
…procsy

Make inspection value for Example::Procsy be the same as class name of it

---
This commit was imported from rspec/rspec-core@3974015.
yujinakayama pushed a commit to yujinakayama/rspec-monorepo that referenced this pull request Oct 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants