сleanups of close/release inconsistency (#182)

remove Frame.release and Payload.release (use close instead)
use close instead of release everywhere
use sealed in composite and auth metadata

Co-authored-by: olme04 <olme04>

Author: olme04

benchmarks/src/kotlinMain/kotlin/io/rsocket/kotlin/benchmarks/RSocketKotlinBenchmark.kt

@@ -43,15 +43,15 @@ class RSocketKotlinBenchmark : RSocketBenchmark<Payload>() {
         val server = RSocketServer().bindIn(CoroutineScope(benchJob + Dispatchers.Unconfined), LocalServerTransport()) {
             RSocketRequestHandler {
                 requestResponse {
-                    it.release()
+                    it.close()
                     payloadCopy()
                 }
                 requestStream {
-                    it.release()
+                    it.close()
                     payloadsFlow
                 }
                 requestChannel { init, payloads ->
-                    init.release()
+                    init.close()
                     payloads.flowOn(requestStrategy)
                 }
             }
@@ -74,7 +74,7 @@ class RSocketKotlinBenchmark : RSocketBenchmark<Payload>() {
     )
 
     override fun releasePayload(payload: Payload) {
-        payload.release()
+        payload.close()
     }
 
     override suspend fun doRequestResponse(): Payload = client.requestResponse(payloadCopy())

examples/multiplatform-chat/src/clientMain/kotlin/ChatApi.kt

@@ -34,6 +34,6 @@ actual class ChatApi(private val rSocket: RSocket, private val proto: ProtoBuf)
     actual suspend fun delete(id: Int) {
         rSocket.requestResponse(
             proto.encodeToPayload(route = "chats.delete", DeleteChat(id))
-        ).release()
+        ).close()
     }
 }

rsocket-core/src/commonMain/kotlin/io/rsocket/kotlin/RSocket.kt

@@ -24,27 +24,27 @@ import kotlinx.coroutines.flow.*
 public interface RSocket : CoroutineScope {
 
     public suspend fun metadataPush(metadata: ByteReadPacket) {
-        metadata.release()
+        metadata.close()
         notImplemented("Metadata Push")
     }
 
     public suspend fun fireAndForget(payload: Payload) {
-        payload.release()
+        payload.close()
         notImplemented("Fire and Forget")
     }
 
     public suspend fun requestResponse(payload: Payload): Payload {
-        payload.release()
+        payload.close()
         notImplemented("Request Response")
     }
 
     public fun requestStream(payload: Payload): Flow<Payload> {
-        payload.release()
+        payload.close()
         notImplemented("Request Stream")
     }
 
     public fun requestChannel(initPayload: Payload, payloads: Flow<Payload>): Flow<Payload> {
-        initPayload.release()
+        initPayload.close()
         notImplemented("Request Channel")
     }
 }

rsocket-core/src/commonMain/kotlin/io/rsocket/kotlin/core/RSocketConnector.kt

@@ -73,8 +73,8 @@ public class RSocketConnector internal constructor(
             connection.sendFrame(setupFrame)
             return requester
         } catch (cause: Throwable) {
-            connectionConfig.setupPayload.release()
-            setupFrame.release()
+            connectionConfig.setupPayload.close()
+            setupFrame.close()
             connection.cancel("Connection establishment failed", cause)
             throw cause
         }

rsocket-core/src/commonMain/kotlin/io/rsocket/kotlin/core/RSocketConnectorBuilder.kt

@@ -113,7 +113,7 @@ public class RSocketConnectorBuilder internal constructor() {
 
     private companion object {
         private val defaultAcceptor: ConnectionAcceptor = ConnectionAcceptor {
-            config.setupPayload.release()
+            config.setupPayload.close()
             EmptyRSocket()
         }
 

rsocket-core/src/commonMain/kotlin/io/rsocket/kotlin/frame/CancelFrame.kt

@@ -24,7 +24,7 @@ internal class CancelFrame(
     override val type: FrameType get() = FrameType.Cancel
     override val flags: Int get() = 0
 
-    override fun release(): Unit = Unit
+    override fun close(): Unit = Unit
 
     override fun BytePacketBuilder.writeSelf(): Unit = Unit
 

rsocket-core/src/commonMain/kotlin/io/rsocket/kotlin/frame/ErrorFrame.kt

@@ -27,7 +27,7 @@ internal class ErrorFrame(
     override val flags: Int get() = 0
     val errorCode get() = (throwable as? RSocketError)?.errorCode ?: ErrorCode.ApplicationError
 
-    override fun release(): Unit = Unit
+    override fun close(): Unit = Unit
 
     override fun BytePacketBuilder.writeSelf() {
         writeInt(errorCode)

rsocket-core/src/commonMain/kotlin/io/rsocket/kotlin/frame/ExtensionFrame.kt

@@ -30,8 +30,8 @@ internal class ExtensionFrame(
     override val type: FrameType get() = FrameType.Extension
     override val flags: Int get() = if (payload.metadata != null) Flags.Metadata else 0
 
-    override fun release() {
-        payload.release()
+    override fun close() {
+        payload.close()
     }
 
     override fun BytePacketBuilder.writeSelf() {

rsocket-core/src/commonMain/kotlin/io/rsocket/kotlin/frame/Frame.kt

@@ -29,8 +29,6 @@ public sealed class Frame : Closeable {
     public abstract val streamId: Int
     public abstract val flags: Int
 
-    internal abstract fun release()
-
     protected abstract fun BytePacketBuilder.writeSelf()
     protected abstract fun StringBuilder.appendFlags()
     protected abstract fun StringBuilder.appendSelf()
@@ -54,10 +52,6 @@ public sealed class Frame : Closeable {
         append(flag)
         if (value) append(1) else append(0)
     }
-
-    override fun close() {
-        release()
-    }
 }
 
 internal fun ByteReadPacket.readFrame(pool: ObjectPool<ChunkBuffer>): Frame = use {

rsocket-core/src/commonMain/kotlin/io/rsocket/kotlin/frame/KeepAliveFrame.kt

@@ -32,8 +32,8 @@ internal class KeepAliveFrame(
     override val streamId: Int get() = 0
     override val flags: Int get() = if (respond) RespondFlag else 0
 
-    override fun release() {
-        data.release()
+    override fun close() {
+        data.close()
     }
 
     override fun BytePacketBuilder.writeSelf() {