Back out "exception_wrapper thrown variant via abi/runtime"

Summary: D26331579 (b286305) was the offending diff that caused an insta crash on Messenger Android and Instagram Android. Backing out for now.

Reviewed By: JunqiWang

Differential Revision: D28308563

fbshipit-source-id: 87a547d9ba7cb3b33a4ddee9e273943f8379d990

Author: Crystal Jin

rsocket/test/transport/TcpDuplexConnectionTest.cpp

@@ -109,5 +109,25 @@ TEST(TcpDuplexConnection, ConnectionAndSubscribersAreUntied) {
       worker.getEventBase());
 }
 
+TEST(TcpDuplexConnection, ExceptionWrapperTest) {
+  folly::AsyncSocketException socketException(
+      folly::AsyncSocketException::AsyncSocketExceptionType::INVALID_STATE,
+      "test",
+      10);
+  folly::SSLException sslException(5, 10, 15, 20);
+
+  const folly::AsyncSocketException& socketExceptionRef = sslException;
+
+  folly::exception_wrapper ex1(socketException);
+  folly::exception_wrapper ex2(sslException);
+
+  // Slicing error:
+  // folly::exception_wrapper ex3(socketExceptionRef);
+
+  // Fixed version:
+  folly::exception_wrapper ex3(
+      std::make_exception_ptr(socketExceptionRef), socketExceptionRef);
+}
+
 } // namespace tests
 } // namespace rsocket

rsocket/transports/tcp/TcpDuplexConnection.cpp

@@ -109,7 +109,7 @@ class TcpReaderWriter : public folly::AsyncTransportWrapper::WriteCallback,
 
   void writeErr(size_t, const folly::AsyncSocketException& exn) noexcept
       override {
-    closeErr(folly::exception_wrapper{folly::copy(exn)});
+    closeErr(folly::exception_wrapper{std::make_exception_ptr(exn), exn});
     intrusive_ptr_release(this);
   }
 
@@ -134,7 +134,7 @@ class TcpReaderWriter : public folly::AsyncTransportWrapper::WriteCallback,
   }
 
   void readErr(const folly::AsyncSocketException& exn) noexcept override {
-    closeErr(folly::exception_wrapper{folly::copy(exn)});
+    closeErr(folly::exception_wrapper{std::make_exception_ptr(exn), exn});
     intrusive_ptr_release(this);
   }