From 7f43e99e853f1a3c5d1dd20d78a3abd92393f830 Mon Sep 17 00:00:00 2001 From: Ben White Date: Mon, 15 May 2023 13:03:59 +0200 Subject: [PATCH 1/3] Warn instead of throwing error when parsing for console logs --- .../rrweb/src/plugins/console/record/error-stack-parser.ts | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/packages/rrweb/src/plugins/console/record/error-stack-parser.ts b/packages/rrweb/src/plugins/console/record/error-stack-parser.ts index 4c0e49c309..86ec597df5 100644 --- a/packages/rrweb/src/plugins/console/record/error-stack-parser.ts +++ b/packages/rrweb/src/plugins/console/record/error-stack-parser.ts @@ -71,7 +71,8 @@ export const ErrorStackParser = { } else if (error.stack) { return this.parseFFOrSafari(error as { stack: string }); } else { - throw new Error('Cannot parse given Error object'); + console.warn("[console-record-plugin]: Failed to parse error object") + return [] } }, // Separate line and column numbers from a string of the form: (URI:Line:Column) From 08e3217798fa6f087513d5abbbd1578b4e740871 Mon Sep 17 00:00:00 2001 From: Ben White Date: Mon, 15 May 2023 13:05:00 +0200 Subject: [PATCH 2/3] Added error to warning --- packages/rrweb/src/plugins/console/record/error-stack-parser.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/rrweb/src/plugins/console/record/error-stack-parser.ts b/packages/rrweb/src/plugins/console/record/error-stack-parser.ts index 86ec597df5..5b6abac8ff 100644 --- a/packages/rrweb/src/plugins/console/record/error-stack-parser.ts +++ b/packages/rrweb/src/plugins/console/record/error-stack-parser.ts @@ -71,7 +71,7 @@ export const ErrorStackParser = { } else if (error.stack) { return this.parseFFOrSafari(error as { stack: string }); } else { - console.warn("[console-record-plugin]: Failed to parse error object") + console.warn("[console-record-plugin]: Failed to parse error object:", error) return [] } }, From 046acf4d5ceff0bc987f8f97f50094ffdd2acc2d Mon Sep 17 00:00:00 2001 From: benjackwhite Date: Mon, 15 May 2023 11:08:15 +0000 Subject: [PATCH 3/3] Apply formatting changes --- .../rrweb/src/plugins/console/record/error-stack-parser.ts | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/packages/rrweb/src/plugins/console/record/error-stack-parser.ts b/packages/rrweb/src/plugins/console/record/error-stack-parser.ts index 5b6abac8ff..b34487935e 100644 --- a/packages/rrweb/src/plugins/console/record/error-stack-parser.ts +++ b/packages/rrweb/src/plugins/console/record/error-stack-parser.ts @@ -71,8 +71,11 @@ export const ErrorStackParser = { } else if (error.stack) { return this.parseFFOrSafari(error as { stack: string }); } else { - console.warn("[console-record-plugin]: Failed to parse error object:", error) - return [] + console.warn( + '[console-record-plugin]: Failed to parse error object:', + error, + ); + return []; } }, // Separate line and column numbers from a string of the form: (URI:Line:Column)