From a62a0a0b16555ecc5ab1dc7171fe6353a452b22d Mon Sep 17 00:00:00 2001 From: Eoghan Murray Date: Fri, 3 Mar 2023 14:47:13 +0000 Subject: [PATCH 1/2] Update CONTRIBUTING.md Add info about Changesets --- CONTRIBUTING.md | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index d5b2014ae5..e6a2d4f28c 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -10,13 +10,14 @@ the process for contributing will follow standard GitHub protocol. ## Pull Requests -We actively welcome your pull requests. +We actively welcome your pull requests (PRs)! 1. Fork the repo and create your branch from `master`. 2. If you've added code that should be tested, add tests -3. If you've changed APIs, update the documentation. -4. Ensure the test suite passes. -5. Make sure your code lints and typechecks. +5. Ensure the test suite passes or ask for help as to why tests are failing +3. We use [changesets](https://github.com/changesets/changesets/blob/main/docs/intro-to-using-changesets.md) to enable you to easily document your PR so that it can be packaged up into the next release. A github plugin will prompt you to fill in your changeset if you haven't already done so. +4. If you've changed APIs, update the documentation. +6. Make sure your code lints and typechecks. ## Issues From 069e6f75d432f79b931924aa65ff6df0817f443f Mon Sep 17 00:00:00 2001 From: eoghanmurray Date: Fri, 3 Mar 2023 14:48:34 +0000 Subject: [PATCH 2/2] Apply formatting changes --- .changeset/young-timers-grow.md | 2 +- CONTRIBUTING.md | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/.changeset/young-timers-grow.md b/.changeset/young-timers-grow.md index e2f9b6b76a..dbb00cc780 100644 --- a/.changeset/young-timers-grow.md +++ b/.changeset/young-timers-grow.md @@ -1,5 +1,5 @@ --- -"rrweb": bugfix +'rrweb': bugfix --- For users of userTriggeredOnInput setting: also set userTriggered to false on Input attribute modifications; this was previously empty this variant of IncrementalSource.Input diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index e6a2d4f28c..991d5b80ee 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -14,9 +14,9 @@ We actively welcome your pull requests (PRs)! 1. Fork the repo and create your branch from `master`. 2. If you've added code that should be tested, add tests -5. Ensure the test suite passes or ask for help as to why tests are failing -3. We use [changesets](https://github.com/changesets/changesets/blob/main/docs/intro-to-using-changesets.md) to enable you to easily document your PR so that it can be packaged up into the next release. A github plugin will prompt you to fill in your changeset if you haven't already done so. -4. If you've changed APIs, update the documentation. +3. Ensure the test suite passes or ask for help as to why tests are failing +4. We use [changesets](https://github.com/changesets/changesets/blob/main/docs/intro-to-using-changesets.md) to enable you to easily document your PR so that it can be packaged up into the next release. A github plugin will prompt you to fill in your changeset if you haven't already done so. +5. If you've changed APIs, update the documentation. 6. Make sure your code lints and typechecks. ## Issues