Skip to content

Commit dfcfee4

Browse files
committed
Create assetStatus type as per Justin's request
1 parent c88f8d8 commit dfcfee4

File tree

2 files changed

+11
-7
lines changed

2 files changed

+11
-7
lines changed

packages/rrweb/src/record/observers/asset-manager.ts

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ import { encode } from 'base64-arraybuffer';
1010

1111
import { patch } from '../../utils';
1212

13-
import type { recordOptions } from '../../types';
13+
import type { recordOptions, assetStatus } from '../../types';
1414
import { isAttributeCapturable, getSourcesFromSrcset } from 'rrweb-snapshot';
1515

1616
export default class AssetManager {
@@ -126,9 +126,7 @@ export default class AssetManager {
126126
}
127127
}
128128

129-
public capture(asset: asset): {
130-
status: 'capturing' | 'captured' | 'error' | 'refused';
131-
} {
129+
public capture(asset: asset): assetStatus {
132130
if (asset.attr === 'srcset') {
133131
getSourcesFromSrcset(asset.value).forEach((url) => {
134132
this.captureUrl(url);
@@ -138,9 +136,7 @@ export default class AssetManager {
138136
}
139137
}
140138

141-
public captureUrl(url): {
142-
status: 'capturing' | 'captured' | 'error' | 'refused';
143-
} {
139+
public captureUrl(url): assetStatus {
144140
if (this.shouldIgnore(url)) return { status: 'refused' };
145141

146142
if (this.capturedURLs.has(url)) {

packages/rrweb/src/types.ts

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -226,3 +226,11 @@ export type CrossOriginIframeMessageEvent =
226226
MessageEvent<CrossOriginIframeMessageEventContent>;
227227

228228
export type ErrorHandler = (error: unknown) => void | boolean;
229+
230+
export type assetStatus = {
231+
status:
232+
| 'capturing'
233+
| 'captured'
234+
| 'error'
235+
| 'refused'
236+
};

0 commit comments

Comments
 (0)