Skip to content

[CMake] Build rootcint and genreflex as separate targets #19769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[CMake] Build rootcint and genreflex as separate targets #19769

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 14 additions & 36 deletions main/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,52 +94,30 @@ set_source_files_properties(src/rootcling.cxx PROPERTIES
VISIBILITY_INLINES_HIDDEN "ON"
)

ROOT_EXECUTABLE(rootcling src/rootcling.cxx LIBRARIES RIO Cling Core Rint)
set(rootcling_exe_names rootcling genreflex rootcint)

foreach(exe_name IN LISTS rootcling_exe_names)
ROOT_EXECUTABLE(${exe_name} src/rootcling.cxx LIBRARIES RIO Cling Core Rint)

# rootcling includes the ROOT complex header which would build the complex
# dictionary with modules. To make sure that rootcling_stage1 builds this
# dict before we use it, we add a dependency here.
add_dependencies(rootcling complexDict)
add_dependencies(${exe_name} complexDict)

target_include_directories(rootcling PRIVATE
target_include_directories(${exe_name} PRIVATE
${CMAKE_SOURCE_DIR}/core/metacling/res
${CMAKE_SOURCE_DIR}/core/dictgen/res
${CMAKE_SOURCE_DIR}/io/rootpcm/res)
set_property(TARGET rootcling PROPERTY ENABLE_EXPORTS 1)
set_property(TARGET ${exe_name} PROPERTY ENABLE_EXPORTS 1)
if(WIN32)
set_target_properties(rootcling PROPERTIES WINDOWS_EXPORT_ALL_SYMBOLS 1)
set_property(TARGET rootcling APPEND_STRING PROPERTY LINK_FLAGS " -STACK:4000000")
set_target_properties(${exe_name} PROPERTIES WINDOWS_EXPORT_ALL_SYMBOLS 1)
set_property(TARGET ${exe_name} APPEND_STRING PROPERTY LINK_FLAGS " -STACK:4000000")
endif()
endforeach()

ROOT_EXECUTABLE(rootls src/rootls.cxx LIBRARIES RIO Tree Core Rint ROOTNTuple)
# To inherit the dependencies from rootcling
add_dependencies(genreflex rootcling)
add_dependencies(rootcint rootcint)

# Create aliases: rootcint, genreflex.
if(WIN32)
add_custom_command(TARGET rootcling POST_BUILD
COMMAND copy /y rootcling.exe rootcint.exe
COMMAND copy /y rootcling.exe genreflex.exe
WORKING_DIRECTORY ${CMAKE_RUNTIME_OUTPUT_DIRECTORY})
else()
add_custom_command(TARGET rootcling POST_BUILD
COMMAND ln -f rootcling rootcint
COMMAND ln -f rootcling genreflex
WORKING_DIRECTORY ${CMAKE_RUNTIME_OUTPUT_DIRECTORY})
endif()
set_directory_properties(PROPERTIES ADDITIONAL_MAKE_CLEAN_FILES
"${CMAKE_RUNTIME_OUTPUT_DIRECTORY}/rootcint;${CMAKE_RUNTIME_OUTPUT_DIRECTORY}/genreflex")

if(CMAKE_HOST_UNIX)
install(CODE "execute_process(COMMAND ln -f rootcling rootcint WORKING_DIRECTORY \$ENV{DESTDIR}\${CMAKE_INSTALL_PREFIX}/${CMAKE_INSTALL_BINDIR})" COMPONENT applications)
install(CODE "execute_process(COMMAND ln -f rootcling genreflex WORKING_DIRECTORY \$ENV{DESTDIR}\${CMAKE_INSTALL_PREFIX}/${CMAKE_INSTALL_BINDIR})" COMPONENT applications)
else()
if(MSVC)
install(PROGRAMS ${CMAKE_RUNTIME_OUTPUT_DIRECTORY}/rootcling.exe DESTINATION ${CMAKE_INSTALL_BINDIR} COMPONENT applications)
install(PROGRAMS ${CMAKE_RUNTIME_OUTPUT_DIRECTORY}/rootcint.exe DESTINATION ${CMAKE_INSTALL_BINDIR} COMPONENT applications)
install(PROGRAMS ${CMAKE_RUNTIME_OUTPUT_DIRECTORY}/genreflex.exe DESTINATION ${CMAKE_INSTALL_BINDIR} COMPONENT applications)
else()
install(PROGRAMS ${CMAKE_RUNTIME_OUTPUT_DIRECTORY}/rootcint
${CMAKE_RUNTIME_OUTPUT_DIRECTORY}/genreflex
${CMAKE_RUNTIME_OUTPUT_DIRECTORY}/rlibmap
DESTINATION ${CMAKE_INSTALL_BINDIR} COMPONENT applications)
endif()
endif()
ROOT_EXECUTABLE(rootls src/rootls.cxx LIBRARIES RIO Tree Core Rint ROOTNTuple)
6 changes: 2 additions & 4 deletions tree/ntuple/test/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,12 +98,10 @@ ROOT_GENERATE_DICTIONARY(StreamerFieldDict ${CMAKE_CURRENT_SOURCE_DIR}/StreamerF
DEPENDENCIES RIO)

if(MSVC)
set(genreflex ${CMAKE_BINARY_DIR}/bin/genreflex.exe)
set(command ${CMAKE_COMMAND} -E env "ROOTIGNOREPREFIX=1" ${genreflex})
set(command ${CMAKE_COMMAND} -E env "ROOTIGNOREPREFIX=1" $<TARGET_FILE:genreflex>)
else()
set(genreflex ${CMAKE_BINARY_DIR}/bin/genreflex)
set(command ${CMAKE_COMMAND} -E env "LD_LIBRARY_PATH=${CMAKE_BINARY_DIR}/lib:$ENV{LD_LIBRARY_PATH}"
"ROOTIGNOREPREFIX=1" ${genreflex})
"ROOTIGNOREPREFIX=1" $<TARGET_FILE:genreflex>)
endif()

configure_file(StreamerFieldXML.h . COPYONLY)
Expand Down
Loading