Fixed behavior of RunnableSelect::fetchGroups

rkrx · rkrx · commit 7855c9ecca53 · 2014-11-03T15:57:21.000+01:00
diff --git a/src/Builder/RunnableSelect.php b/src/Builder/RunnableSelect.php
@@ -116,10 +116,12 @@ public function fetchGroups(array $fields) {
 			$tmp = &$result;
 			foreach($fields as $field) {
 				$value = $row[$field];
-				$tmp[$value] = [];
+				if(!array_key_exists($value, $tmp)) {
+					$tmp[$value] = [];
+				}
 				$tmp = &$tmp[$value];
 			}
-			$tmp = $row;
+			$tmp[] = $row;
 		}
 		return $result;
 	}

Original file line number	Diff line number	Diff line change
`@@ -116,10 +116,12 @@ public function fetchGroups(array $fields) {`
`116`	`116`	`$tmp = &$result;`
`117`	`117`	`foreach($fields as $field) {`
`118`	`118`	`$value = $row[$field];`
`119`		`- $tmp[$value] = [];`
	`119`	`+ if(!array_key_exists($value, $tmp)) {`
	`120`	`+ $tmp[$value] = [];`
	`121`	`+ }`
`120`	`122`	`$tmp = &$tmp[$value];`
`121`	`123`	`}`
`122`		`- $tmp = $row;`
	`124`	`+ $tmp[] = $row;`
`123`	`125`	`}`
`124`	`126`	`return $result;`
`125`	`127`	`}`