From efa698d43b72de61a68911f2b6391d77f4d65d4d Mon Sep 17 00:00:00 2001 From: congyi <15605187270@163.com> Date: Wed, 26 Mar 2025 22:02:18 +0800 Subject: [PATCH 1/3] public txn.generate_unique_snapshot_id --- crates/iceberg/src/spec/manifest/_serde.rs | 2 +- crates/iceberg/src/transaction/mod.rs | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/crates/iceberg/src/spec/manifest/_serde.rs b/crates/iceberg/src/spec/manifest/_serde.rs index 0f15479d95..40e707f62b 100644 --- a/crates/iceberg/src/spec/manifest/_serde.rs +++ b/crates/iceberg/src/spec/manifest/_serde.rs @@ -97,7 +97,7 @@ impl ManifestEntryV1 { } #[serde_as] -#[derive(Serialize, Deserialize)] +#[derive(Serialize, Deserialize, Clone)] /// Data file pub struct DataFileSerde { #[serde(default)] diff --git a/crates/iceberg/src/transaction/mod.rs b/crates/iceberg/src/transaction/mod.rs index d79747a8c6..25524ef6fd 100644 --- a/crates/iceberg/src/transaction/mod.rs +++ b/crates/iceberg/src/transaction/mod.rs @@ -131,7 +131,7 @@ impl<'a> Transaction<'a> { Ok(self) } - fn generate_unique_snapshot_id(&self) -> i64 { + pub fn generate_unique_snapshot_id(&self) -> i64 { let generate_random_id = || -> i64 { let (lhs, rhs) = Uuid::new_v4().as_u64_pair(); let snapshot_id = (lhs ^ rhs) as i64; From 9f37306d8ba3e98dfb6d416a611e137cd50a8685 Mon Sep 17 00:00:00 2001 From: congyi <15605187270@163.com> Date: Wed, 26 Mar 2025 22:09:50 +0800 Subject: [PATCH 2/3] add comment --- crates/iceberg/src/transaction/mod.rs | 1 + 1 file changed, 1 insertion(+) diff --git a/crates/iceberg/src/transaction/mod.rs b/crates/iceberg/src/transaction/mod.rs index 25524ef6fd..245898a582 100644 --- a/crates/iceberg/src/transaction/mod.rs +++ b/crates/iceberg/src/transaction/mod.rs @@ -131,6 +131,7 @@ impl<'a> Transaction<'a> { Ok(self) } + /// Generate a new `snapshot_id`. pub fn generate_unique_snapshot_id(&self) -> i64 { let generate_random_id = || -> i64 { let (lhs, rhs) = Uuid::new_v4().as_u64_pair(); From 2a7201831daf1a1e30f5d053bdb6056cb41ff93e Mon Sep 17 00:00:00 2001 From: congyi <15605187270@163.com> Date: Thu, 27 Mar 2025 10:36:52 +0800 Subject: [PATCH 3/3] empty commit for retry