Skip to content

ci: rename commitlint.config.js to commitlint.config.mjs #482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 14, 2024
Merged

ci: rename commitlint.config.js to commitlint.config.mjs #482

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9d2f6eb
ci: rename commitlint.config.js to commitlint.config.mjs
jan--f May 14, 2024
7acb580
ci: fix commitlint config format
jan--f May 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/pr-checks.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ jobs:
- uses: actions/checkout@v4
with:
fetch-depth: 0
- uses: wagoid/commitlint-github-action@v5
- uses: wagoid/commitlint-github-action@v6

github-actions-yaml-lint:
runs-on: ubuntu-latest
Expand Down
2 changes: 1 addition & 1 deletion commitlint.config.js → commitlint.config.mjs
View file
Open in desktop
Copy link
Contributor

@danielmellado danielmellado May 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We would need to change module.exports to export default Configuration; in here to comply with the ES module syntax.

Copy link
Collaborator Author

@jan--f jan--f May 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like so?

Copy link
Contributor

@danielmellado danielmellado May 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, I think that should make it.

Original file line number Diff line number Diff line change
Expand Up @@ -9,4 +9,4 @@ const Configuration = {
ignores: [(msg) => /Signed-off-by: dependabot\[bot]/m.test(msg)],
};

module.exports = Configuration;
export default Configuration
Copy link
Contributor

@danielmellado danielmellado May 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
export default Configuration
export default Configuration;

Copy link
Contributor

@danielmellado danielmellado May 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's keep the end trailing even if it does seem that it works without it.