Fix: a failed invocation to another service should throw an error in the user code

Author: gvdongen

src/state_machine.ts

@@ -1206,7 +1206,7 @@ export class DurableExecutionStateMachine<I, O> implements RestateContext {
       }
     } else if (failure !== undefined) {
       if (pendingMessage.reject !== undefined) {
-        pendingMessage.reject(failure);
+        pendingMessage.reject(new Error(failure.message));
         this.indexToPendingMsgMap.delete(journalIndex);
       } else {
         // leads to onCallFailure call

test/protoutils.ts

@@ -185,7 +185,8 @@ export function invokeMessage(
   serviceName: string,
   methodName: string,
   parameter: Uint8Array,
-  value?: Uint8Array
+  value?: Uint8Array,
+  failure?: Failure
 ): Message {
   if (value != undefined) {
     return new Message(
@@ -197,6 +198,16 @@ export function invokeMessage(
         value: Buffer.from(value),
       })
     );
+  } else if (failure != undefined) {
+    return new Message(
+      INVOKE_ENTRY_MESSAGE_TYPE,
+      InvokeEntryMessage.create({
+        serviceName: serviceName,
+        methodName: methodName,
+        parameter: Buffer.from(parameter),
+        failure: failure,
+      })
+    );
   } else {
     return new Message(
       INVOKE_ENTRY_MESSAGE_TYPE,

test/send_request.test.ts

@@ -22,6 +22,7 @@ import {
   TestResponse,
 } from "../src/generated/proto/test";
 import { ProtocolMode } from "../src/generated/proto/discovery";
+import { Failure } from "../src/generated/proto/protocol";
 
 class ReverseAwaitOrder implements TestGreeter {
   // eslint-disable-next-line @typescript-eslint/no-unused-vars
@@ -92,6 +93,36 @@ class FailingSideEffectInBackgroundInvokeGreeter implements TestGreeter {
   }
 }
 
+class FailingForwardGreetingService implements TestGreeter {
+  // eslint-disable-next-line @typescript-eslint/no-unused-vars
+  async greet(request: TestRequest): Promise<TestResponse> {
+    const ctx = restate.useContext(this);
+
+    const client = new TestGreeterClientImpl(ctx);
+
+    try {
+      // This will get an failure back as a completion or replay message
+      // eslint-disable-next-line @typescript-eslint/no-unused-vars
+      const greeting = await client.greet(
+        TestRequest.create({ name: "Francesco" })
+      );
+    } catch (error) {
+      if (error instanceof Error) {
+        // If we call another service and get back a failure.
+        // The failure should be thrown in the user code.
+        return TestResponse.create({
+          greeting: `Hello ${error.message}`,
+        });
+      }
+      throw new Error("Error is not instanceof Error: " + typeof error);
+    }
+
+    return TestResponse.create({
+      greeting: `Hello, you shouldn't be here...`,
+    });
+  }
+}
+
 describe("ReverseAwaitOrder: None completed", () => {
   it("should call greet", async () => {
     const result = await new TestDriver(
@@ -400,6 +431,68 @@ This gives the following error:
 //   });
 // });
 
+describe("FailingForwardGreetingService: call failed - replay", () => {
+  it("should call greet", async () => {
+    const result = await new TestDriver(
+      protoMetadata,
+      "TestGreeter",
+      new FailingForwardGreetingService(),
+      "/test.TestGreeter/Greet",
+      [
+        startMessage(2),
+        inputMessage(greetRequest("Till")),
+        invokeMessage(
+          "test.TestGreeter",
+          "Greet",
+          greetRequest("Francesco"),
+          undefined,
+          Failure.create({
+            code: 13,
+            message: "Sorry, something went terribly wrong...",
+          })
+        ),
+      ]
+    ).run();
+
+    expect(result).toStrictEqual([
+      outputMessage(
+        greetResponse("Hello Sorry, something went terribly wrong...")
+      ),
+    ]);
+  });
+});
+
+describe("FailingForwardGreetingService: call failed - completion", () => {
+  it("should call greet", async () => {
+    const result = await new TestDriver(
+      protoMetadata,
+      "TestGreeter",
+      new FailingForwardGreetingService(),
+      "/test.TestGreeter/Greet",
+      [
+        startMessage(1),
+        inputMessage(greetRequest("Till")),
+        completionMessage(
+          1,
+          undefined,
+          undefined,
+          Failure.create({
+            code: 13,
+            message: "Sorry, something went terribly wrong...",
+          })
+        ),
+      ]
+    ).run();
+
+    expect(result).toStrictEqual([
+      invokeMessage("test.TestGreeter", "Greet", greetRequest("Francesco")),
+      outputMessage(
+        greetResponse("Hello Sorry, something went terribly wrong...")
+      ),
+    ]);
+  });
+});
+
 // async calls
 describe("BackgroundInvokeGreeter: background call ", () => {
   it("should call greet", async () => {