deprecate WithParams functions

Author: Freddy03h

src/BottomTabs.res

@@ -137,8 +137,8 @@ type navigatorModule
 module Make = () => unpack(createBottomTabNavigator()->adaptNavigatorModule)
 
 module Navigation = {
-  @send external jumpTo: (navigation, string) => unit = "jumpTo"
-  @send
+  @send external jumpTo: (navigation, string, ~params: 'params=?) => unit = "jumpTo"
+  @deprecated("Use `jumpTo` with `~params` instead") @send
   external jumpToWithParams: (navigation, string, 'params) => unit = "jumpTo"
 
   @send

src/Core.res

@@ -64,22 +64,18 @@ type layoutNavigatorParams = {
 module Navigation = {
   type t = navigation
 
-  @send external navigate: (t, string) => unit = "navigate"
-  @send
+  @send external navigate: (t, string, ~params: 'params=?) => unit = "navigate"
+  @deprecated("Use `navigate` with `~params` instead") @send
   external navigateWithParams: (t, string, 'params) => unit = "navigate"
 
-  @send external navigateDeprecated: (t, string) => unit = "navigateDeprecated"
-  @send
-  external navigateDeprecatedWithParams: (t, string, 'params) => unit = "navigateDeprecated"
+  @send external navigateDeprecated: (t, string, ~params: 'params=?) => unit = "navigateDeprecated"
 
   @send external goBack: (navigation, unit) => unit = "goBack"
 
   @send
   external reset: (navigation, navigationState) => unit = "reset"
 
-  @send external preload: (t, string) => unit = "preload"
-  @send
-  external preloadWithParams: (t, string, 'params) => unit = "preload"
+  @send external preload: (t, string, ~params: 'params=?) => unit = "preload"
 
   @send external isFocused: (navigation, unit) => bool = "isFocused"
 

src/Example.bs.js

@@ -40,7 +40,6 @@ function Example$MainStackScreen(props) {
                         options: (function (props) {
                             var params = props.route.params;
                             return {
-                                    title: params !== undefined ? Caml_option.valFromOption(params).name : "Reason",
                                     headerRight: (function (param) {
                                         return JsxRuntime.jsx(ReactNative.Button, {
                                                     color: "#f00",
@@ -49,7 +48,8 @@ function Example$MainStackScreen(props) {
                                                       }),
                                                     title: "Info"
                                                   });
-                                      })
+                                      }),
+                                    title: params !== undefined ? Caml_option.valFromOption(params).name : "Reason"
                                   };
                           }),
                         component: Example$HomeScreen

src/MaterialBottomTabs.res

@@ -84,8 +84,8 @@ module Navigation = {
   @send
   external setOptions: (navigation, options) => unit = "setOptions"
 
-  @send external jumpTo: (navigation, string) => unit = "jumpTo"
-  @send
+  @send external jumpTo: (navigation, string, ~params: 'params=?) => unit = "jumpTo"
+  @deprecated("Use `jumpTo` with `~params` instead") @send
   external jumpToWithParams: (navigation, string, 'params) => unit = "jumpTo"
 
   @send

src/NativeStack.res

@@ -224,18 +224,17 @@ module Navigation = {
   @send
   external setOptions: (navigation, options) => unit = "setOptions"
 
-  @send external replace: (navigation, string) => unit = "replace"
-  @send
+  @send external replace: (navigation, string, ~params: 'params=?) => unit = "replace"
+  @deprecated("Use `replace` with `~params` instead") @send
   external replaceWithParams: (navigation, string, 'params) => unit = "replace"
 
-  @send external push: (navigation, string) => unit = "push"
-  @send external pushWithParams: (navigation, string, 'params) => unit = "push"
+  @send external push: (navigation, string, ~params: 'params=?) => unit = "push"
+  @deprecated("Use `push` with `~params` instead") @send
+  external pushWithParams: (navigation, string, 'params) => unit = "push"
 
   @send external pop: (navigation, ~count: int=?, unit) => unit = "pop"
 
-  @send external popTo: (navigation, string) => unit = "popTo"
-  @send
-  external popToWithParams: (navigation, string, 'params) => unit = "popTo"
+  @send external popTo: (navigation, string, ~params: 'params=?) => unit = "popTo"
 
   @send external popToTop: (navigation, unit) => unit = "popToTop"
 

src/Stack.res

@@ -208,18 +208,17 @@ module Navigation = {
   @send
   external setOptions: (navigation, options) => unit = "setOptions"
 
-  @send external replace: (navigation, string) => unit = "replace"
-  @send
+  @send external replace: (navigation, string, ~params: 'params=?) => unit = "replace"
+  @deprecated("Use `replace` with `~params` instead") @send
   external replaceWithParams: (navigation, string, 'params) => unit = "replace"
 
-  @send external push: (navigation, string) => unit = "push"
-  @send external pushWithParams: (navigation, string, 'params) => unit = "push"
+  @send external push: (navigation, string, ~params: 'params=?) => unit = "push"
+  @deprecated("Use `push` with `~params` instead") @send
+  external pushWithParams: (navigation, string, 'params) => unit = "push"
 
   @send external pop: (navigation, ~count: int=?, unit) => unit = "pop"
 
-  @send external popTo: (navigation, string) => unit = "popTo"
-  @send
-  external popToWithParams: (navigation, string, 'params) => unit = "popTo"
+  @send external popTo: (navigation, string, ~params: 'params=?) => unit = "popTo"
 
   @send external popToTop: (navigation, unit) => unit = "popToTop"