Drop OCaml Array module

Author: cometkim

jscomp/core/lam_analysis.ml

@@ -46,7 +46,7 @@ let rec no_side_effects (lam : Lam.t) : bool =
               (
               (* more safe to check if arguments are constant *)
               (* non-observable side effect *)
-              "?make_vect" | "?obj_dup" | "caml_array_dup" ),
+              "?obj_dup" ),
               _ ) ->
               true
           | _, _ -> false)

jscomp/core/lam_dispatch_primitive.ml

@@ -136,12 +136,6 @@ let translate loc (prim_name : string) (args : J.expression list) : J.expression
       like normal one to set the identifier *)
   | "?exn_slot_name" | "?is_extension" -> call Js_runtime_modules.exceptions
   | "?as_js_exn" -> call Js_runtime_modules.caml_js_exceptions
-  | "?array_sub" -> E.runtime_call Js_runtime_modules.array "sub" args
-  | "?array_concat" -> E.runtime_call Js_runtime_modules.array "concat" args
-  (*external concat: 'a array list -> 'a array
-     Not good for inline *)
-  | "?array_blit" -> E.runtime_call Js_runtime_modules.array "blit" args
-  | "?make_vect" -> E.runtime_call Js_runtime_modules.array "make" args
   | "?obj_dup" -> call Js_runtime_modules.obj_runtime
   | "?obj_tag" -> (
       (* Note that in ocaml, [int] has tag [1000] and [string] has tag [252]

jscomp/ext/js_runtime_modules.ml

@@ -32,6 +32,8 @@ let bigint = "Primitive_bigint"
 
 let string = "Primitive_string"
 
+let array = "Primitive_array"
+
 let deriving = "Runtime_deriving"
 
 let promise = "Runtime_promise"
@@ -42,8 +44,6 @@ let exceptions = "Caml_exceptions"
 
 let obj_runtime = "Caml_obj"
 
-let array = "Caml_array"
-
 let hash_primitive = "Caml_hash_primitive"
 
 let hash = "Caml_hash"

jscomp/runtime/caml_array.res

@@ -35,11 +35,11 @@ type rec shape =
   | Class
   | Module(array<(shape, string)>)
   | Value(Obj.t)
-/* ATTENTION: check across versions */
-module Array = Caml_array_extern
 
-@set_index external set_field: (Obj.t, string, Obj.t) => unit = ""
+@get external array_length: array<'a> => int = "length"
+@get_index external array_unsafe_get: (array<'a>, int) => 'a = ""
 
+@set_index external set_field: (Obj.t, string, Obj.t) => unit = ""
 @get_index external get_field: (Obj.t, string) => Obj.t = ""
 
 module type Empty = {}
@@ -69,9 +69,9 @@ let init_mod = (loc: (string, int, int), shape: shape) => {
     | Module(comps) =>
       let v = Obj.repr(module({}: Empty))
       set_field(struct_, idx, v)
-      let len = Array.length(comps)
+      let len = array_length(comps)
       for i in 0 to len - 1 {
-        let (shape, name) = Caml_array_extern.unsafe_get(comps, i)
+        let (shape, name) = array_unsafe_get(comps, i)
         loop(shape, v, name)
       }
     | Value(v) => set_field(struct_, idx, v)
@@ -94,16 +94,16 @@ let update_mod = (shape: shape, o: Obj.t, n: Obj.t): unit => {
     | Class =>
       Caml_obj.update_dummy(o, n)
     | Module(comps) =>
-      for i in 0 to Array.length(comps) - 1 {
-        let (shape, name) = Caml_array_extern.unsafe_get(comps, i)
+      for i in 0 to array_length(comps) - 1 {
+        let (shape, name) = array_unsafe_get(comps, i)
         aux(shape, get_field(o, name), get_field(n, name), o, name)
       }
     | Value(_) => ()
     }
   switch shape {
   | Module(comps) =>
-    for i in 0 to Array.length(comps) - 1 {
-      let (shape, name) = Caml_array_extern.unsafe_get(comps, i)
+    for i in 0 to array_length(comps) - 1 {
+      let (shape, name) = array_unsafe_get(comps, i)
       aux(shape, get_field(o, name), get_field(n, name), o, name)
     }
   | _ => assert(false)

jscomp/runtime/caml_array.resi

@@ -22,6 +22,8 @@
  * along with this program; if not, write to the Free Software
  * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. */
 
+external array_unsafe_get: (array<'a>, int) => 'a = "%array_unsafe_get"
+
 type t = Obj.t
 
 module O = {
@@ -69,7 +71,6 @@ module O = {
        var new_record = u.slice ()
 
    ]}
-   `obj_dup` is a superset of `array_dup`
 */
 let obj_dup: Obj.t => Obj.t = %raw(`function(x){
   if(Array.isArray(x)){
@@ -234,7 +235,7 @@ and aux_same_length = (a: array<Obj.t>, b: array<Obj.t>, i, same_length) =>
   if i == same_length {
     0
   } else {
-    let res = compare(Caml_array_extern.unsafe_get(a, i), Caml_array_extern.unsafe_get(b, i))
+    let res = compare(array_unsafe_get(a, i), array_unsafe_get(b, i))
 
     if res != 0 {
       res
@@ -247,7 +248,7 @@ and aux_length_a_short = (a: array<Obj.t>, b: array<Obj.t>, i, short_length) =>
   if i == short_length {
     -1
   } else {
-    let res = compare(Caml_array_extern.unsafe_get(a, i), Caml_array_extern.unsafe_get(b, i))
+    let res = compare(array_unsafe_get(a, i), array_unsafe_get(b, i))
 
     if res != 0 {
       res
@@ -260,7 +261,7 @@ and aux_length_b_short = (a: array<Obj.t>, b: array<Obj.t>, i, short_length) =>
   if i == short_length {
     1
   } else {
-    let res = compare(Caml_array_extern.unsafe_get(a, i), Caml_array_extern.unsafe_get(b, i))
+    let res = compare(array_unsafe_get(a, i), array_unsafe_get(b, i))
 
     if res != 0 {
       res
@@ -359,7 +360,7 @@ and aux_equal_length = (a: array<Obj.t>, b: array<Obj.t>, i, same_length) =>
   if i == same_length {
     true
   } else {
-    equal(Caml_array_extern.unsafe_get(a, i), Caml_array_extern.unsafe_get(b, i)) &&
+    equal(array_unsafe_get(a, i), array_unsafe_get(b, i)) &&
     aux_equal_length(a, b, i + 1, same_length)
   }
 

jscomp/runtime/caml_array_extern.res

@@ -24,12 +24,14 @@
 
 @@uncurried
 
+@get external array_length: array<'a> => int = "length"
+@send external array_slice: (array<'a>, int, int) => array<'a> = "slice"
+@send external array_concat: (array<'a>, array<'a>) => array<'a> = "concat"
+
 /* Generated by scripts/curry_gen.ml */
 external function_length: 'a => int = "#function_length"
 external apply_args: ('a => 'b, array<_>) => 'b = "#apply"
 
-let _ = Caml_array.sub /* make the build dependency on Caml_array explicit */
-%%private(let sub = Caml_array.sub)
 /* Public */
 let rec app = (f, args) => {
   let init_arity = function_length(f)
@@ -38,15 +40,15 @@ let rec app = (f, args) => {
   } else {
     init_arity
   } /* arity fixing */
-  let len = Caml_array_extern.length(args)
+  let len = array_length(args)
   let d = arity - len
   if d == 0 {
     apply_args(f, args) /* f.apply (null,args) */
   } else if d < 0 {
     /* TODO: could avoid copy by tracking the index */
-    app(Obj.magic(apply_args(f, sub(args, 0, arity))), sub(args, arity, -d))
+    app(Obj.magic(apply_args(f, array_slice(args, 0, arity))), array_slice(args, arity, len))
   } else {
-    Obj.magic(x => app(f, Caml_array_extern.append(args, [x])))
+    Obj.magic(x => app(f, array_concat(args, [x])))
   }
 }
 

jscomp/runtime/caml_module.res

@@ -0,0 +1,19 @@
+@get external length: array<'a> => int = "length"
+
+@get_index external get: (array<'a>, int) => 'a = ""
+
+let get = (xs, index) =>
+  if index < 0 || index >= length(xs) {
+    raise(Invalid_argument("index out of bounds"))
+  } else {
+    xs->get(index)
+  }
+
+@set_index external set: (array<'a>, int, 'a) => unit = ""
+
+let set = (xs, index, newval) =>
+  if index < 0 || index >= length(xs) {
+    raise(Invalid_argument("index out of bounds"))
+  } else {
+    xs->set(index, newval)
+  }