Skip to content

Commit 3b9b8ff

Browse files
authored
Have biome check all files, not just changed ones (#7856)
1 parent e723459 commit 3b9b8ff

File tree

4 files changed

+12
-13
lines changed

4 files changed

+12
-13
lines changed

biome.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,8 @@
7373
"*.gen.ts*",
7474
"*.d.ts",
7575
"*.exe",
76-
"package.json"
76+
"package.json",
77+
"packages/artifacts.json"
7778
]
7879
}
7980
}

cli/common/bsb.js

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -72,8 +72,8 @@ function acquireBuild(args, options) {
7272
* @param {(code: number) => void} [maybeOnClose]
7373
*/
7474
function delegate(args, maybeOnClose) {
75-
let p;
76-
if ((p = acquireBuild(args))) {
75+
const p = acquireBuild(args);
76+
if (p) {
7777
p.once("error", e => {
7878
console.error(String(e));
7979
releaseBuild();
@@ -376,12 +376,10 @@ Please pick a different one using the \`-ws [host:]port\` flag from bsb.`);
376376
return;
377377
}
378378
dlog(`Rebuilding since ${reasonsToRebuild}`);
379-
let p;
380-
if (
381-
(p = acquireBuild(rescriptWatchBuildArgs, {
382-
stdio: ["inherit", "inherit", "pipe"],
383-
}))
384-
) {
379+
const p = acquireBuild(rescriptWatchBuildArgs, {
380+
stdio: ["inherit", "inherit", "pipe"],
381+
});
382+
if (p) {
385383
logStartCompiling();
386384
p.on("data", s => {
387385
outputError(s, "ninja: error");

cli/rescript.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ let forwardedSignal = false;
2929
/**
3030
* @param {NodeJS.Signals} signal
3131
*/
32-
const handleSignal = (signal) => {
32+
const handleSignal = signal => {
3333
// Intercept the signal in the parent, forward it to the child, and let the
3434
// child perform its own cleanup. This ensures ordered shutdown in watch mode.
3535
// Guard against double-forwarding since terminals or OSes can deliver
@@ -85,7 +85,7 @@ child.on("exit", (code, signal) => {
8585
});
8686

8787
// Surface spawn errors (e.g., executable not found) and exit with failure.
88-
child.on("error", (err) => {
88+
child.on("error", err => {
8989
console.error(err?.message ?? String(err));
9090
process.exit(1);
9191
});

package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -48,9 +48,9 @@
4848
"test": "node scripts/test.js -all",
4949
"test-bsb": "node scripts/test.js -bsb",
5050
"test-ocaml": "node scripts/test.js -ounit",
51-
"check": "biome check --changed --no-errors-on-unmatched .",
51+
"check": "biome check --no-errors-on-unmatched .",
5252
"check:all": "biome check .",
53-
"format": "biome check --changed --no-errors-on-unmatched . --fix",
53+
"format": "biome check --no-errors-on-unmatched . --fix",
5454
"coverage": "nyc --timeout=3000 --reporter=html mocha tests/tests/src/*_test.js && open ./coverage/index.html",
5555
"typecheck": "tsc",
5656
"apidocs:generate": "yarn workspace @utils/scripts apidocs:generate"

0 commit comments

Comments
 (0)