test(syntax): use regex literal in test files

necessary to pass syntax roundtrip test since printing has changed

Author: glennsl

jscomp/syntax/tests/idempotency/nook-exchange/App.res

@@ -64,7 +64,7 @@ let make = () => {
   let url = ReasonReactRouter.useUrl()
   let (showLogin, setShowLogin) = React.useState(() => false)
   let itemDetails = {
-    let result = url.hash |> Js.Re.exec_(%re("/i(-?\d+)(:(\d+))?/g"))
+    let result = url.hash |> Js.Re.exec_(/i(-?\d+)(:(\d+))?/g)
     switch result {
     | Some(match_) =>
       let captures = Js.Re.captures(match_)

jscomp/syntax/tests/idempotency/nook-exchange/Emoji.res

@@ -31,7 +31,7 @@ module Styles = {
   let emoji = style(list{verticalAlign(#bottom), position(relative), top(px(-2))})
 }
 
-let emojiRegex = %re(`/(^|\\s)(\\:[a-zA-Z0-9-_+]+\\:)/g`)
+let emojiRegex = /(^|\s)(\:[a-zA-Z0-9-_+]+\:)/g
 
 let parseText = (text: string): React.element => {
   let children = []

jscomp/syntax/tests/idempotency/nook-exchange/ImportPage.res

@@ -654,7 +654,7 @@ let process = value => {
   let resultMap = Js.Dict.empty()
   let missingQueries = []
   rows->Array.forEach(row => {
-    let result = row |> Js.Re.exec_(%re("/(.*?) \[(.*?)\]$/g"))
+    let result = row |> Js.Re.exec_(/(.*?) \[(.*?)\]$/g)
     let itemWithVariant = switch result {
     | Some(match_) =>
       let captures = Js.Re.captures(match_)

jscomp/syntax/tests/idempotency/nook-exchange/Item.res

@@ -82,7 +82,7 @@ let loadTranslation: (string, Js.Json.t => unit) => unit = %raw(`function(langua
 
 exception UnexpectedType(string)
 
-let spaceRegex = %re("/\\s/g")
+let spaceRegex = /\s/g
 
 exception Unexpected
 let jsonToItems = (json: Js.Json.t) => {

jscomp/syntax/tests/idempotency/nook-exchange/ItemFilters.res

@@ -206,7 +206,7 @@ let doesItemMatchCategory = (~item: Item.t, ~category: string) =>
   }
 
 let removeAccents = str =>
-  str |> Js.String.normalizeByForm("NFD") |> Js.String.replaceByRe(%re("/[\u0300-\u036f]/g"), "")
+  str |> Js.String.normalizeByForm("NFD") |> Js.String.replaceByRe(/[\u0300-\u036f]/g, "")
 
 let doesItemMatchFilters = (~item: Item.t, ~filters: t) =>
   switch filters.text {
@@ -218,7 +218,7 @@ let doesItemMatchFilters = (~item: Item.t, ~filters: t) =>
     | None => false
     } || {
       let fragments =
-        (textLower |> Js.String.splitByRe(%re(`/[\\s-]+/`)))->Belt.Array.keepMap(x => x)
+        (textLower |> Js.String.splitByRe(/[\s-]+/))->Belt.Array.keepMap(x => x)
       fragments->Belt.Array.every(fragment =>
         Js.String.toLowerCase(Item.getName(item))
         |> removeAccents
@@ -253,8 +253,8 @@ let compareArrays = (a, b) => {
 
 let compareItemsABC = (a: Item.t, b: Item.t) => {
   // hack to sort "wooden-" before "wooden "
-  let aName = Item.getName(a) |> Js.String.replaceByRe(%re("/-/g"), " ")
-  let bName = Item.getName(b) |> Js.String.replaceByRe(%re("/-/g"), " ")
+  let aName = Item.getName(a) |> Js.String.replaceByRe(/-/g, " ")
+  let bName = Item.getName(b) |> Js.String.replaceByRe(/-/g, " ")
   int_of_float(Js.String.localeCompare(bName, aName))
 }
 let compareItemsSellPriceDesc = (a: Item.t, b: Item.t) =>
@@ -798,7 +798,7 @@ let make = (
       | "Escape" =>
         let url = ReasonReactRouter.dangerouslyGetInitialUrl()
         // don't trigger if ItemDetailOverlay is shown
-        if !(url.hash |> Js.Re.test_(%re("/i(-?\d+)(:(\d+))?/g"))) {
+        if !(url.hash |> Js.Re.test_(/i(-?\d+)(:(\d+))?/g)) {
           onChange({...filters, text: ""})
         }
       | "/" =>

jscomp/syntax/tests/idempotency/nook-exchange/UserStore.res

@@ -477,7 +477,7 @@ let toggleCatalogCheckboxSetting = (~enabled) => {
   )
 }
 
-let errorQuotationMarksRegex = %re(`/^"(.*)"$/`)
+let errorQuotationMarksRegex = /^"(.*)"$/
 let register = (~username, ~email, ~password) =>
   %Repromise.JsExn({
     let response = Fetch.fetchWithInit(

jscomp/syntax/tests/idempotency/pupilfirst/questions/QuestionsShow__QuestionEditor.res

@@ -183,7 +183,7 @@ module UpdateQuestionError = {
 let handleResponseCB = (id, title) => {
   let window = Webapi.Dom.window
   let parameterizedTitle =
-    title |> Js.String.toLowerCase |> Js.String.replaceByRe(%re("/[^0-9a-zA-Z]+/gi"), "-")
+    title |> Js.String.toLowerCase |> Js.String.replaceByRe(/[^0-9a-zA-Z]+/gi, "-")
   let redirectPath = "/questions/" ++ (id ++ ("/" ++ parameterizedTitle))
   redirectPath |> Webapi.Dom.Window.setLocation(window)
 }

jscomp/syntax/tests/idempotency/pupilfirst/schools/CurriculumEditor__ContentBlockCreator.res

@@ -292,10 +292,10 @@ let updateEmbedUrl = (send, event) => {
 }
 
 let embedUrlRegexes = [
-  %re("/https:\\/\\/.*slideshare\\.net/"),
-  %re("/https:\\/\\/.*vimeo\\.com/"),
-  %re("/https:\\/\\/.*youtube\\.com/"),
-  %re("/https:\\/\\/.*youtu\\.be/"),
+  /https:\/\/.*slideshare\.net/,
+  /https:\/\/.*vimeo\.com/,
+  /https:\/\/.*youtube\.com/,
+  /https:\/\/.*youtu\.be/,
 ]
 
 let validEmbedUrl = url => Belt.Array.some(embedUrlRegexes, regex => regex->Js.Re.test_(url))

jscomp/syntax/tests/idempotency/pupilfirst/schools/SA_Coaches_CoachEditor.res

@@ -94,7 +94,7 @@ let updateEmail = (send, email) => send(UpdateEmail(email, email |> emailInvalid
 let updateTitle = (send, title) => send(UpdateTitle(title, title |> nameOrTitleInvalid))
 
 let updateLinkedInUrl = (send, linkedinUrl) => {
-  let regex = %re(`/(https?)?:?(\\/\\/)?(([w]{3}||\\w\\w)\\.)?linkedin.com(\\w+:{0,1}\\w*@)?(\\S+)(:([0-9])+)?(\\/|\\/([\\w#!:.?+=&%@!\\-\\/]))?/`)
+  let regex = /(https?)?:?(\/\/)?(([w]{3}||\w\w)\.)?linkedin.com(\w+:{0,1}\w*@)?(\S+)(:([0-9])+)?(\/|\/([\w#!:.?+=&%@!\-\/]))?/
   let hasError = linkedinUrl |> String.length < 1 ? false : !Js.Re.test_(regex, linkedinUrl)
   send(UpdateLinkedInUrl(linkedinUrl, hasError))
 }

jscomp/syntax/tests/idempotency/pupilfirst/schools/StudentsEditor__StudentInfoForm.res

@@ -29,7 +29,7 @@ let updateName = (send, name) => {
 }
 
 let updateEmail = (send, email) => {
-  let regex = %re(`/.+@.+\\..+/i`)
+  let regex = /.+@.+\..+/i
   let hasError = !Js.Re.test_(regex, email)
   send(UpdateEmail(email, hasError))
 }