Account for "public" setting in bsconfig #824
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cristianoc
approved these changes
Oct 5, 2023
|
Not documented I think, at least not anymore. I don't understand why though, because it seems like a great feature to get around that you can't really hide top level modules. I'd definitively want to keep the feature, at least OTOH. But I think posting on the forum about it might be good. Maybe someone remembers if this was deprecated at some point and if so why, given that it isn't documented from what I can see. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This accounts for the "public" setting in
bsconfig. Seems like a fairly hidden property, but we should still support it imo given that trying to use something not listed in public (when public is set) is an error, even though items appear in autocomplete.Example from the forum: https://forum.rescript-lang.org/t/how-to-only-expose-one-module-from-a-lib/4744/2