From ea21163deb8b91ad0de5cdbf2dd603852d0d6d31 Mon Sep 17 00:00:00 2001 From: Cristiano Calcagno Date: Fri, 21 Oct 2022 10:11:22 +0200 Subject: [PATCH 1/2] Fis issue where module paths in `-open` `bsc-flags` such as "-open ReScriptJs.Js" were not recognized Fixes https://github.com/rescript-lang/rescript-vscode/issues/607 --- CHANGELOG.md | 4 ++++ analysis/src/Packages.ml | 4 +++- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 49625aa95..9029d4ec2 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -12,6 +12,10 @@ ## master +#### :bug: Bug Fix + +- Fix issue where module paths in `-open` `bsc-flags` such as "-open ReScriptJs.Js" were not recognized https://github.com/rescript-lang/rescript-vscode/issues/607 + ## v1.8.1 #### :rocket: New Feature diff --git a/analysis/src/Packages.ml b/analysis/src/Packages.ml index 029158348..c43ca71d9 100644 --- a/analysis/src/Packages.ml +++ b/analysis/src/Packages.ml @@ -68,7 +68,9 @@ let newBsPackage ~rootPath = | Some s -> ( let parts = String.split_on_char ' ' s in match parts with - | "-open" :: name :: _ -> name :: opens + | "-open" :: name :: _ -> + let names = name |> String.split_on_char '.' in + names @ opens | _ -> opens)) [] l | None -> [] From ac1b0d14de62d198cca2450bdc7bb28e18152bf3 Mon Sep 17 00:00:00 2001 From: Cristiano Calcagno Date: Fri, 21 Oct 2022 10:13:57 +0200 Subject: [PATCH 2/2] Update CHANGELOG.md --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 9029d4ec2..0d505627f 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -14,7 +14,7 @@ #### :bug: Bug Fix -- Fix issue where module paths in `-open` `bsc-flags` such as "-open ReScriptJs.Js" were not recognized https://github.com/rescript-lang/rescript-vscode/issues/607 +- Fix issue where module paths in `-open` in `bsc-flags` such as "-open ReScriptJs.Js" were not recognized https://github.com/rescript-lang/rescript-vscode/issues/607 ## v1.8.1