Skip to content

Add macos-arm binary #565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 3, 2022
Merged

Add macos-arm binary #565

merged 1 commit into from
Sep 3, 2022

Conversation

cknitt
Copy link
Member

@cknitt cknitt commented Sep 3, 2022

This adds the rescript-editor-analysis.exe binary for macOS ARM.

@cknitt cknitt marked this pull request as draft September 3, 2022 16:05
Copy link
Collaborator

@cristianoc cristianoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet.

@cristianoc
Copy link
Collaborator

It's not packaged yet right?

@cknitt
Copy link
Member Author

cknitt commented Sep 3, 2022

Still WIP/testing at the moment.

@cknitt
Copy link
Member Author

cknitt commented Sep 3, 2022

Tested with the resulting VSIX, seems to work fine now. 😄
(Meaning that the binary is packaged now and used on macOS ARM.)

@cknitt cknitt marked this pull request as ready for review September 3, 2022 16:54
@cknitt cknitt requested a review from cristianoc September 3, 2022 16:56
@cknitt cknitt linked an issue Sep 3, 2022 that may be closed by this pull request
@cknitt cknitt mentioned this pull request Sep 3, 2022
@cknitt cknitt merged commit 17f762d into rescript-lang:master Sep 3, 2022
@cknitt cknitt deleted the macos-arm branch September 3, 2022 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for aarch64
2 participants