chore: fix broken tests

Author: brennj

src/jsonLogic.js

@@ -22,6 +22,7 @@ export function createValidationChecker(schema) {
   const scopes = new Map();
 
   function createScopes(jsonSchema, key = 'root') {
+    const sampleEmptyObject = buildSampleEmptyObject(schema);
     scopes.set(key, createValidationsScope(jsonSchema));
     Object.entries(jsonSchema?.properties ?? {})
       .filter(([, property]) => property.type === 'object' || property.type === 'array')
@@ -31,6 +32,8 @@ export function createValidationChecker(schema) {
         }
         createScopes(property, key);
       });
+
+    validateInlineRules(jsonSchema, sampleEmptyObject);
   }
 
   createScopes(schema);
@@ -297,15 +300,39 @@ function buildSampleEmptyObject(schema = {}) {
   return sample;
 }
 
-function checkRuleIntegrity(rule, id, data) {
+function validateInlineRules(jsonSchema, sampleEmptyObject) {
+  const properties = (jsonSchema?.properties || jsonSchema?.items?.properties) ?? {};
+  Object.entries(properties)
+    .filter(([, property]) => property['x-jsf-computedAttributes'] !== undefined)
+    .forEach(([fieldName, property]) => {
+      Object.entries(property['x-jsf-computedAttributes'])
+        .filter(([, value]) => typeof value === 'object')
+        .forEach(([key, { rule }]) => {
+          checkRuleIntegrity(
+            rule,
+            fieldName,
+            sampleEmptyObject,
+            (item) =>
+              `"${item.var}" in inline rule in property "${fieldName}.x-jsf-computedAttributes.${key}" does not exist as a JSON schema property.`
+          );
+        });
+    });
+}
+
+function checkRuleIntegrity(
+  rule,
+  id,
+  data,
+  errorMessage = (item) => `"${item.var}" in rule "${id}" does not exist as a JSON schema property.`
+) {
   Object.values(rule ?? {}).map((subRule) => {
     if (!Array.isArray(subRule) && subRule !== null && subRule !== undefined) return;
     subRule.map((item) => {
       const isVar = item !== null && typeof item === 'object' && Object.hasOwn(item, 'var');
       if (isVar) {
         const exists = jsonLogic.apply({ var: removeIndicesFromPath(item.var) }, data);
         if (exists === null) {
-          throw Error(`"${item.var}" in rule "${id}" does not exist as a JSON schema property.`);
+          throw Error(errorMessage(item));
         }
       } else {
         checkRuleIntegrity(item, id, data);

src/tests/jsonLogic.test.js

@@ -22,6 +22,7 @@ import {
   schemaWithGreaterThanChecksForThreeFields,
   schemaWithIfStatementWithComputedValuesAndValidationChecks,
   schemaWithInlineRuleForComputedAttributeWithCopy,
+  schemaWithInlinedRuleOnComputedAttributeThatReferencesUnknownVar,
   schemaWithMissingRule,
   schemaWithMultipleComputedValueChecks,
   schemaWithNativeAndJSONLogicChecks,
@@ -178,9 +179,17 @@ describe('cross-value validations', () => {
       );
     });
 
-    it.todo(
-      'On an inline rule for a computedAttribute, error if theres a value referenced that does not exist'
-    );
+    it('On an inline rule for a computedAttribute, error if theres a value referenced that does not exist', () => {
+      createHeadlessForm(schemaWithInlinedRuleOnComputedAttributeThatReferencesUnknownVar, {
+        strictInputType: false,
+      });
+      expect(console.error).toHaveBeenCalledWith(
+        'JSON Schema invalid!',
+        Error(
+          '"IdontExist" in inline rule in property "field_a.x-jsf-computedAttributes.title" does not exist as a JSON schema property.'
+        )
+      );
+    });
   });
 
   describe('Relative: <, >, =', () => {
@@ -515,7 +524,7 @@ describe('cross-value validations', () => {
         }
       );
       const [, fieldB] = fields;
-      expect(handleValidation({ field_a: 0 }).formErrors).toEqual(undefined);
+      expect(handleValidation({ field_a: 0, field_b: null }).formErrors).toEqual(undefined);
       expect(fieldB.label).toEqual('I need this to work using the 10.');
       expect(handleValidation({ field_a: 10 }).formErrors).toEqual(undefined);
       expect(fieldB.label).toEqual('I need this to work using the 20.');