Skip to content

Commit 2e52614

Browse files
committed
chore: add comment to track NaN bug
1 parent 528fd31 commit 2e52614

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

src/tests/jsonLogic.test.js

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -401,6 +401,10 @@ describe('jsonLogic: cross-values validations', () => {
401401
}
402402
);
403403
const [, fieldB] = fields;
404+
405+
// FIXME: We are currently setting NaN here because of how the data clean up works for json-logic
406+
// We should probably set this as undefined when theres no values set?
407+
// tracked in INF-53.
404408
expect(fieldB).toMatchObject({ minimum: NaN, maximum: NaN });
405409
expect(handleValidation({ field_a: 10, field_b: null }).formErrors).toBeUndefined();
406410
expect(fieldB).toMatchObject({ minimum: 0, maximum: 20 });

0 commit comments

Comments
 (0)