Remove instanceof Response checks in favor of isResponse #9690
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
@remix-run/routerfor server-side data fetching, we seem to get differentResponseinstances from areturn fetch(...)in aloader/action.I'm not entirely sure why yet since we polyfill allfetch/Request/Responseglobals, but theinstanceof Responsechecks were failing. Copied the sameisResponsemethod used in Remix and replaced all checks with that.I think the underlying cause here is that our
loaderis built via ESM and uses the ESM version of the fetch polyfills, but@remix-run/server-runtime+@remix-run/routerare runningin node and therefore using the CJS versions of the fetch polyfills. Hence theinstanceoffailing.Closes remix-run/remix#4741