diff --git a/contributors.yml b/contributors.yml index 205fe06b05..1f2681fc79 100644 --- a/contributors.yml +++ b/contributors.yml @@ -19,6 +19,7 @@ - chensokheng - chrisngobanh - christopherchudzicki +- codeape2 - coryhouse - cvbuelow - david-crespo diff --git a/packages/react-router-dom/__tests__/link-href-test.tsx b/packages/react-router-dom/__tests__/link-href-test.tsx index 9ec368fc70..01fd6905d4 100644 --- a/packages/react-router-dom/__tests__/link-href-test.tsx +++ b/packages/react-router-dom/__tests__/link-href-test.tsx @@ -1,6 +1,15 @@ import * as React from "react"; import * as TestRenderer from "react-test-renderer"; -import { MemoryRouter, Routes, Route, Link, Outlet } from "react-router-dom"; +import { + MemoryRouter, + Routes, + Route, + Link, + Outlet, + HashRouter, + createHashRouter, + RouterProvider +} from "react-router-dom"; describe(" href", () => { describe("in a static route", () => { @@ -679,4 +688,38 @@ describe(" href", () => { ); }); }); + + describe("when using ", () => { + test("rendered hrefs contain #", () => { + let renderer: TestRenderer.ReactTestRenderer; + TestRenderer.act(() => { + renderer = TestRenderer.create( + + + } /> + + + ); + }); + expect(renderer.root.findByType("a").props.href).toEqual("#/about"); + }); + }); + + describe("when using createHashRouter", () => { + test("rendered hrefs contain #", () => { + let renderer: TestRenderer.ReactTestRenderer; + TestRenderer.act(() => { + const router = createHashRouter([ + { + path: "/", + element: + } + ]); + renderer = TestRenderer.create( + + ); + }); + expect(renderer.root.findByType("a").props.href).toEqual("#/about"); + }); + }); });