Skip to content

Conversation

@MichaelDeBoey
Copy link
Member

@MichaelDeBoey MichaelDeBoey commented Jun 7, 2022

Just like I did in remix-run/remix#3360

@ryanflorence
Copy link
Member

I'm not sure we need this? React Router doesn't know or care about Node.js. Is this just for development/contributing?

@MichaelDeBoey
Copy link
Member Author

@ryanflorence It shows which Node/JS version is supported by the package.
It important for both development/contributing + for installing the package as a dependency of a project, as the code could maybe use newer API's, so we want to let the people using the package know that.

@MichaelDeBoey MichaelDeBoey force-pushed the add-engines-to-packages branch from a643229 to b9aefa9 Compare June 10, 2022 20:27
@changeset-bot
Copy link

changeset-bot bot commented Sep 9, 2022

⚠️ No Changeset found

Latest commit: 30a29ee

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@brophdawg11
Copy link
Contributor

Thanks @MichaelDeBoey!

@brophdawg11 brophdawg11 merged commit ab0da65 into remix-run:dev Sep 9, 2022
@MichaelDeBoey MichaelDeBoey deleted the add-engines-to-packages branch September 11, 2022 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants