Provide a URL to replaceState for compatibility with jsdom

jdufresne · jdufresne · commit 7f1dc91d08fd · 2023-01-29T14:55:27.000-08:00
Workaround upstream jsdom bug: jsdom/jsdom#3504 The third argument to replaceState is optional, but provide it anyway for improved compatibility with all environments. The call to replaceState was introduced in bb7590a.
diff --git a/packages/router/history.ts b/packages/router/history.ts
@@ -603,7 +603,7 @@ function getUrlBasedHistory(
   // case we should log a warning as it will result in bugs.
   if (index == null) {
     index = 0;
-    globalHistory.replaceState({ ...globalHistory.state, idx: index }, "");
+    globalHistory.replaceState({ ...globalHistory.state, idx: index }, "", window.location.href);
   }
 
   function getIndex(): number {

Original file line number	Diff line number	Diff line change
`@@ -603,7 +603,7 @@ function getUrlBasedHistory(`
`603`	`603`	`// case we should log a warning as it will result in bugs.`
`604`	`604`	`if (index == null) {`
`605`	`605`	`index = 0;`
`606`		`- globalHistory.replaceState({ ...globalHistory.state, idx: index }, "");`
	`606`	`+ globalHistory.replaceState({ ...globalHistory.state, idx: index }, "", window.location.href);`
`607`	`607`	`}`
`608`	`608`
`609`	`609`	`function getIndex(): number {`