Skip to content

Fixes coreference results, updates jar directory #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 22, 2014
Merged

Fixes coreference results, updates jar directory #1

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9a5b7b1
Fixes coreference results
dcalacci Jan 22, 2014
8604812
fixes grouping of coreferences
dcalacci Jan 22, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions corenlp/corenlp.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,9 +36,9 @@
VERBOSE = False
STATE_START, STATE_TEXT, STATE_WORDS, STATE_TREE, STATE_DEPENDENCY, STATE_COREFERENCE = 0, 1, 2, 3, 4, 5
WORD_PATTERN = re.compile('\[([^\]]+)\]')
CR_PATTERN = re.compile(r"\((\d*),(\d)*,\[(\d*),(\d*)\)\) -> \((\d*),(\d)*,\[(\d*),(\d*)\)\), that is: \"(.*)\" -> \"(.*)\"")
CR_PATTERN = re.compile(r"\((\d*),(\d)*,\[(\d*),(\d*)[\]\)]\) -> \((\d*),(\d)*,\[(\d*),(\d*)[\]\)]\), that is: \"(.*)\" -> \"(.*)\"")

DIRECTORY = "stanford-corenlp-full-2013-06-20"
DIRECTORY = "stanford-corenlp-full-2014-01-04"


class bc:
Expand Down Expand Up @@ -84,8 +84,8 @@ def init_corenlp_command(corenlp_path, memory, properties):
"""

# TODO: Can edit jar constants
jars = ["stanford-corenlp-3.2.0.jar",
"stanford-corenlp-3.2.0-models.jar",
jars = ["stanford-corenlp-3.3.1.jar",
"stanford-corenlp-3.3.1-models.jar",
"xom.jar",
"joda-time.jar",
"jollyday.jar"]
Expand Down Expand Up @@ -152,7 +152,8 @@ def parse_parser_results(text):
"""
results = {"sentences": []}
state = STATE_START
for line in text.split("\n"):
lines = text.split("\n")
for index, line in enumerate(lines):
line = line.strip()

if line.startswith("Sentence #"):
Expand Down Expand Up @@ -188,7 +189,7 @@ def parse_parser_results(text):
sentence['dependencies'].append(tuple([rel, left, right]))

elif state == STATE_COREFERENCE:
if "Coreference set" in line:
if 'Coreference set' in line:
if 'coref' not in results:
results['coref'] = []
coref_set = []
Expand All @@ -198,7 +199,6 @@ def parse_parser_results(text):
src_i, src_pos, src_l, src_r = int(src_i) - 1, int(src_pos) - 1, int(src_l) - 1, int(src_r) - 1
sink_i, sink_pos, sink_l, sink_r = int(sink_i) - 1, int(sink_pos) - 1, int(sink_l) - 1, int(sink_r) - 1
coref_set.append(((src_word, src_i, src_pos, src_l, src_r), (sink_word, sink_i, sink_pos, sink_l, sink_r)))

return results


Expand Down